Problem

Coffee's js/coffee.js has a hard coded path specified for the 'coffee.get_data' route which causes incompatibility with other modules such as Rename Admin Paths.

Proposed solution

Proposed solution is to retrieve the path for the 'coffee.get_data' route in the coffee_page_attachments() using the Url::fromRoute() method so that the compilation of the path is passed through any outbound processors.

CommentFileSizeAuthor
#2 coffee-pass_get_data_route_via_drupalsettings-2981359-d8.patch1.18 KBamcgowanca

Comments

amcgowanca created an issue. See original summary.

amcgowanca’s picture

amcgowanca commented
StatusFileSize
new coffee-pass_get_data_route_via_drupalsettings-2981359-d8.patch1.18 KB
amcgowanca’s picture

amcgowanca commented
Status: Active » Needs review
coufu’s picture

coufu commented

Great work. Thanks for this!

  • michaelmol committed 43c2987 on 8.x-1.x authored by amcgowanca 
    Issue #2981359 by amcgowanca, Coufu: Get coffee.get_data route path and...
michaelmol’s picture

michaelmol commented
Status: Needs review » Fixed

thanks

stmh’s picture

stmh commented

Hi,

this change breaks multilingual sites as the language prefix gets encoded twice, so its sth like /de/de/admin/coffee/get-data. Will try go create a patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.