Problem/Motivation

In #2788777-184: Allow a site-specific profile to be installed from existing config @larowlan pointed out that that patch was incorrectly merging errors. The code was copied from \Drupal\config\Form\ConfigSync::processBatch() so lets fix that.

Proposed resolution

Use array_merge() and add a test to prove that errors from the batch system and ConfigImporter are merged correctly.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 2979821-5.patch3.08 KBalexpott
#5 2979821-5.test-only.patch2.5 KBalexpott
#4 2979821-4.patch601 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott credited larowlan.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Crediting @larowlan for finding this issue.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2979821-4.patch601 bytes

Here's the fix.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2979821-5.test-only.patch2.5 KB
new 2979821-5.patch3.08 KB

Here's a test.

The last submitted patch, 5: 2979821-5.test-only.patch, failed testing. View results

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Nice catch, fix and test!

  • larowlan committed a9ebc01 on 8.6.x 
    Issue #2979821 by alexpott, larowlan: \Drupal\config\Form\ConfigSync::...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed as a9ebc01 and pushed to 8.6.x.

Cherry-picked as fab20d4 and pushed to 8.5.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.