Quick question folks: does this plugin (the Drupal7 version) support tracking "tel" links? Or is it confined to mailto links at the moment?

CommentFileSizeAuthor
#16 interdiff_11-16.txt8.33 KBchrisolof
#16 google_analytics-track-tel-clicks-2979262-3x-16.patch7.2 KBchrisolof
#16 google_analytics-track-tel-clicks-2979262-2x-16.patch7.26 KBchrisolof
#11 google_analytics-phone_envent_tracking-29792622979262-5.patch5.5 KBthalles
#8 google_analytics-phone_envent_tracking-2979262-4.patch2.72 KBthalles
#5 google_analytics-phone_envent_tracking-2979262.patch2.22 KBthalles
#3 googleanalytics-phone-event-tracking.patch5.56 KBgnindl

Comments

svict4 created an issue. See original summary.

hass’s picture

hass commented
Version: 7.x-2.x-dev » 8.x-2.x-dev
Category: Support request » Feature request

Currently it may not tracked or not as expected. Feel free to share a patch.

gnindl’s picture

gnindl commented
Version: 8.x-2.x-dev » 7.x-2.x-dev
StatusFileSize
new googleanalytics-phone-event-tracking.patch5.56 KB

I made a patch for Drupal 7, see attachment.

hass’s picture

hass commented
Version: 7.x-2.x-dev » 8.x-2.x-dev

Looks all good, but we need a D8 patch first.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new google_analytics-phone_envent_tracking-2979262.patch2.22 KB

Follow the patch!

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: google_analytics-phone_envent_tracking-2979262.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new google_analytics-phone_envent_tracking-2979262-4.patch2.72 KB
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
hass’s picture

hass commented
Status: Needs review » Needs work

Js code and tests are missing.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
StatusFileSize
new google_analytics-phone_envent_tracking-29792622979262-5.patch5.5 KB

Follow the patche

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
hass’s picture

hass commented
Status: Needs review » Needs work

- „Click on e-mail '%s' has been tracked.“ ooks wrong.
- I guess we also need the install file additions and I‘m not sure if we need an update hook to add the install value to existing installations.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

How to emulate this?

millionleaves’s picture

millionleaves commented

Tried the patch in #11 on 8.x-3.x-dev (yes, I know it's a patch for 8.x-2.x-dev).

It appeared to apply OK, but doesn't work. I can enable the option to track tel links, but nothing is showing up in GA when I click a tel link in the site.

Also - minor point - but the checkbox in the admin should be located above the checkbox for "Track downloads (clicks on file links) for the following extensions" - currently it's between the checkbox and the text field for entering extensions. Not sure if that's happening because I installed it into the wrong branch, but just in case...

chrisolof’s picture

chrisolof
he/him
Primary language English
commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Needs work » Needs review
StatusFileSize
new google_analytics-track-tel-clicks-2979262-2x-16.patch7.26 KB
new google_analytics-track-tel-clicks-2979262-3x-16.patch7.2 KB
new interdiff_11-16.txt8.33 KB

The attached patches add tel: link click tracking to both the 2.x and 3.x branches.

I went with a slightly different naming convention ("tel" instead of "phone"), addressed the issues in comment 13, and updated the readme. There's an interdiff showing the differences between my 2.x patch and the patch in comment 11.

Heads-up: I have not personally tested the 2.x patch (my site runs 3.x), but can confirm the 3.x patch is working well in my initial tests here.

Ready for review.

  • japerry committed ea0c375 on 4.x authored by chrisolof 
    Issue #2979262 by thalles, chrisolof, gnindl: Event tracking tel links
japerry’s picture

japerry
Location KOMK
commented
Version: 8.x-3.x-dev » 4.x-dev
Status: Needs review » Fixed

Thanks for the suggestion, committing before we refactor the link tracking in 4.x. Fixed!

Note, there is no ongoing support for 2.x or 3.x branches, so if you need to use those features in those branches, keep continuing to use the patches above.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.