While evaluating this module, we noticed it could use a readme. According to Drupal standards, modules should include a useful README.file.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....

Patch to follow, thanks!

CommentFileSizeAuthor
#6 term_merge-add-readme-2978944-6.patch1.77 KBKarlKedrovsky
#2 term_merge_readme-2978944-2.patch2.29 KBdani3lr0se

Comments

daniel_rose created an issue. See original summary.

dani3lr0se’s picture

dani3lr0se commented
Assigned: dani3lr0se » Unassigned
Status: Active » Needs review
StatusFileSize
new term_merge_readme-2978944-2.patch2.29 KB

Here is a patch that adds a readme that meets Drupal recommended standards. Thanks for your work on the module. :)

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
commented
Status: Needs review » Reviewed & tested by the community

Patch applied using simplytest.me.

Grammar, spelling, and punctuation look good. The links and configurations all make sense.
Thanks! Marking as RTBC.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Reviewed & tested by the community » Needs work

Thank you for your contribution. I've reviewed your patch and found that the recommended modules section mentions features that aren't currently supported in the 8.x version.

  1. +++ b/README.txt
@@ -0,0 +1,77 @@
+Integration with Synonyms: during merge the user can specify to add branch terms
+as synonyms into the trunk term. This way the user can significantly reduce
+probability of getting more synonymous terms in the future.
+
+ * Synonyms - https://www.drupal.org/project/synonyms

    This is not currently supported in the D8 version. 

  2. +++ b/README.txt
@@ -0,0 +1,77 @@
+Integration with Redirect: the user can set up SEO friendly redirects from
+branch terms to the trunk term so the user does not waste the search ranking.
+
+ * Redirect - https://www.drupal.org/project/term_merge

    Neither is this.

To resolve this I'd like the features mentioned removed from the current patch, but see two new feature requests opened with these as the starting patch. We then have something to work on :)

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented

As for the redirect functionality #2939363: Provide "Create Redirect" functionality if redirect module is installed already requests that feature.

KarlKedrovsky’s picture

KarlKedrovsky commented
StatusFileSize
new term_merge-add-readme-2978944-6.patch1.77 KB

Removed the recommended modules section that referenced currently unsupported features.

KarlKedrovsky’s picture

KarlKedrovsky commented

The README.txt file has been added to the "Create Redirect" functionality issue - https://www.drupal.org/project/term_merge/issues/2939363#comment-12795768.

KarlKedrovsky’s picture

KarlKedrovsky commented

New issue for the Synonym functionality added - https://www.drupal.org/project/term_merge/issues/3003356.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Status: Needs work » Fixed

Committed and pushed to 8.x-1.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.