Missing some curly braces and semi colon in the media.css file, also it is missng drupal standard.

CommentFileSizeAuthor
#13 creativity-media-2977996-13.patch649 bytesbandanasharma
#12 media-screenshot.png21.37 KBbandanasharma
#8 creativity-media-2977996-8.patch1.55 KBmahtabalam
#7 creativity-media-2977996-7.patch1.55 KBakshay kashyap
#6 after_applying_patch.png4.06 KBakshay kashyap
#5 creativity-media-2977996-5.patch1.46 KBmahtabalam
#3 creativity-media-2977996-2.patch1017 bytesbandanasharma

Comments

bandanasharma created an issue. See original summary.

bandanasharma’s picture

bandanasharma commented
Parent issue: » #2977690: style.css is missing some curly braces
Related issues: -#2977690: style.css is missing some curly braces
bandanasharma’s picture

bandanasharma commented
Status: Active » Needs review
StatusFileSize
new creativity-media-2977996-2.patch1017 bytes

Added the patch, please review.

mahtabalam’s picture

mahtabalam
He/Him/His
commented
Status: Needs review » Needs work

@bandanasharma , There is some more issue in media.css apart from indentation and drupal standard,
for button5 

  .button5 {
    font-size: 9px;
    padding: 3 10px;
  }

is written.

Also #where, #t2 and #uac1 the rule is same then it should be combine.

mahtabalam’s picture

mahtabalam
He/Him/His
commented
Status: Needs work » Needs review
StatusFileSize
new creativity-media-2977996-5.patch1.46 KB

Please review and apply the patch, which will fix the issue mention on comment #4.

akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new after_applying_patch.png4.06 KB

@Mahtab Alam

when i have applied your patch its gives error, i have attached the screenshot for reference.

akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new creativity-media-2977996-7.patch1.55 KB

I have created patch for the same please review.

mahtabalam’s picture

mahtabalam
He/Him/His
commented
StatusFileSize
new creativity-media-2977996-8.patch1.55 KB

@Akshay thanks, Your patch works but there also need some changes as per drupal standard.

I have updated the patch accordingly and also as per the drupal standard. Please review and apply the same.

gaurav.kapoor’s picture

gaurav.kapoor commented

The patch doesn't apply anymore. Please check if the issue is still valid or not and then only submit a patch. Thanks.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Needs work
bandanasharma’s picture

bandanasharma commented

@gaurav.kapoor This issue is still exist. See the attached file.

bandanasharma’s picture

bandanasharma commented
StatusFileSize
new media-screenshot.png21.37 KB
bandanasharma’s picture

bandanasharma commented
StatusFileSize
new creativity-media-2977996-13.patch649 bytes

Make these changes and upload the patch, review it.

bandanasharma’s picture

bandanasharma commented
Status: Needs work » Needs review
akshay kashyap’s picture

akshay kashyap commented

@bandanasharma

I have reviewed your patch its working fine and changes reflect on media.css file.

akshay kashyap’s picture

akshay kashyap commented
Status: Needs review » Reviewed & tested by the community
meenakshig’s picture

meenakshig commented
Status: Reviewed & tested by the community » Fixed

thanks for the patch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.