Comment for third container in page--front.html.twig file contains a typo.

Comments

manish-31 created an issue. See original summary.

manish-31’s picture

StatusFileSize
new352 bytes

Issue resolved this patch will correct it. Needs Review.

manish-31’s picture

Status: Active » Needs review
bandanasharma’s picture

Status: Needs review » Needs work

@manish-31 patch is apply successfully and resolve the spelling mistake.
But file is not properly indent and also "super creative container" is not properly commented.
It is good, if resolved all the issues related to this file in this thread rather then creating new issue.

manish-31’s picture

Status: Needs work » Needs review
StatusFileSize
new12.55 KB

Indentation issue is solved with this patch please apply and review.

mahtabalam’s picture

Status: Needs review » Needs work

The patch #5 will only solve the indenting but in "page--front.html.twig" there are some more spelling mistakes and div for "third container" section is also missing ">" in <div class="t1" of Portfolios.

Also there is one extra </div> just above <footer>.

mahtabalam’s picture

StatusFileSize
new44.87 KB

I have reviewed "page--front.html.twig" and fixed the indenting along with the other <div> related issue which I have mentioned on #6.
Apart from this I have also checked the .css file and found that the indent is not as per drupal standard.
- In media.css semicolon (;) "{" was missing and indenting was not as per standard.
- In style.css "{" was missing and indenting was not as per standard.

Please review and apply the patch. It will fix the indentation issue, extra </div>, missing { , and ; in "page--front.html.twig" and css files.

mahtabalam’s picture

Status: Needs work » Needs review

Please review and apply the patch "2977487-7.patch"

bandanasharma’s picture

Status: Needs review » Needs work

@Mahtab Alam There is separate issues for style.css file. In this thread only fix "page--front.html.twig" issues.
Don't include html and body tag in the page twig file, also remove script tag and called js function into the separate js file.

bandanasharma’s picture

Component: Documentation » Code
mahtabalam’s picture

Status: Needs work » Needs review
StatusFileSize
new11.45 KB

Hi, I have fixed "page--front.html.twig" issues which is related with indentation, typo, missing div, extra div and also the comment of "super creative container" . Please review and apply the patch.

mahtabalam’s picture

StatusFileSize
new11.41 KB

I have made some more changes in the patch, please review the same.

gaurav.kapoor’s picture

Status: Needs review » Fixed

I have pushed #12 for time being and will be working on other issues. Please create a new issue if you find any new bugs/fixes.

gaurav.kapoor’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.