Closed (fixed)
Project:
Creativity
Version:
8.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
5 Jun 2018 at 12:37 UTC
Updated:
26 Jun 2018 at 07:24 UTC
Jump to comment: Most recent, Most recent file
Comment for third container in page--front.html.twig file contains a typo.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2977487-12.patch | 11.41 KB | mahtabalam |
| #11 | 2977487-11.patch | 11.45 KB | mahtabalam |
| #7 | 2977487-7.patch | 44.87 KB | mahtabalam |
| #5 | 2977487-5.patch | 12.55 KB | manish-31 |
| #2 | 2977487-2.patch | 352 bytes | manish-31 |
Comments
Comment #2
manish-31 commentedIssue resolved this patch will correct it. Needs Review.
Comment #3
manish-31 commentedComment #4
bandanasharma commented@manish-31 patch is apply successfully and resolve the spelling mistake.
But file is not properly indent and also "super creative container" is not properly commented.
It is good, if resolved all the issues related to this file in this thread rather then creating new issue.
Comment #5
manish-31 commentedIndentation issue is solved with this patch please apply and review.
Comment #6
mahtabalamThe patch #5 will only solve the indenting but in "page--front.html.twig" there are some more spelling mistakes and div for "third container" section is also missing ">" in
<div class="t1"of Portfolios.Also there is one extra
</div>just above<footer>.Comment #7
mahtabalamI have reviewed "page--front.html.twig" and fixed the indenting along with the other
<div>related issue which I have mentioned on #6.Apart from this I have also checked the .css file and found that the indent is not as per drupal standard.
- In media.css semicolon (;) "{" was missing and indenting was not as per standard.
- In style.css "{" was missing and indenting was not as per standard.
Please review and apply the patch. It will fix the indentation issue, extra
</div>, missing{, and;in "page--front.html.twig" and css files.Comment #8
mahtabalamPlease review and apply the patch "2977487-7.patch"
Comment #9
bandanasharma commented@Mahtab Alam There is separate issues for style.css file. In this thread only fix "page--front.html.twig" issues.
Don't include html and body tag in the page twig file, also remove script tag and called js function into the separate js file.
Comment #10
bandanasharma commentedComment #11
mahtabalamHi, I have fixed "page--front.html.twig" issues which is related with indentation, typo, missing div, extra div and also the comment of "super creative container" . Please review and apply the patch.
Comment #12
mahtabalamI have made some more changes in the patch, please review the same.
Comment #14
gaurav.kapoor commentedI have pushed #12 for time being and will be working on other issues. Please create a new issue if you find any new bugs/fixes.
Comment #15
gaurav.kapoor commented