Not all the text in the overlay are tokens.

After enabling the base field definition for settings as translatable we could translate the settings. There was only one problem with rendering the language specific value. After some debugging i found a possible solution but i am not sure if this is the correct approche.

CommentFileSizeAuthor
#13 2977441-13.patch18.27 KBmarkhalliwell
#9 background_image-multilingual_support_overlay_text-2977441-9.patch7.97 KBp-neyens
#5 background_image-multilingual_support_overlay_text-2977441-4.patch8.15 KBp-neyens
#5 interdiff_3-4.txt1.04 KBp-neyens
#3 interdiff_2-3.txt981 bytesp-neyens
#3 background_image-multilingual_support_overlay_text-2977441-3.patch8.01 KBp-neyens
#2 background_image-multilingual_support_overlay_text-2977441-2.patch7.43 KBp-neyens

Comments

p-neyens created an issue. See original summary.

p-neyens’s picture

p-neyens commented
Title: The configuration property full_viewport.container doesn't exist » Support multilingual for property "overlay text"
StatusFileSize
new background_image-multilingual_support_overlay_text-2977441-2.patch7.43 KB

After enabling Multilingual(admin/config/regional/content-language) it wasn't possible to translate the overlay text. The only supported property was the label.

p-neyens’s picture

p-neyens commented
StatusFileSize
new background_image-multilingual_support_overlay_text-2977441-3.patch8.01 KB
new interdiff_2-3.txt981 bytes

Move previous text settings to the new fields for existing entities.

p-neyens’s picture

p-neyens commented
Status: Active » Needs review
p-neyens’s picture

p-neyens commented
StatusFileSize
new interdiff_3-4.txt1.04 KB
new background_image-multilingual_support_overlay_text-2977441-4.patch8.15 KB

Fix "Notice: Undefined index: value"

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: p-neyens » Unassigned
Status: Needs review » Needs work

I don't think the above patches are the correct approach. The text_format data type is already marked as "translatable". If it's not showing up as such, then something else needs to be done to the code, not manually defining a custom field.

p-neyens’s picture

p-neyens commented

We could mark the settings fields as translatable but then are all the settings language specific. What we want is only the overlay translatable.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Closed (duplicate)
Related issues: +#2990856: Tokens used in overlay text don't use the translated values
p-neyens’s picture

p-neyens commented
Issue summary: View changes
Status: Closed (duplicate) » Needs review
StatusFileSize
new background_image-multilingual_support_overlay_text-2977441-9.patch7.97 KB
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Closed (duplicate)

@p-neyens, please use the other issue.

p-neyens’s picture

p-neyens commented

@markcarver I already use the patch from the other issue. But this fix only support token translations and not translations for the text string value of a background image.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: Unassigned » markhalliwell
Status: Closed (duplicate) » Needs work

Ah, I see what you're saying.

Ok, going to clean it up a bit.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: markhalliwell » Unassigned
Status: Needs work » Fixed
StatusFileSize
new 2977441-13.patch18.27 KB

  • markcarver committed 9e5acab on 8.x-1.x 
    Issue #2977441 by markcarver, p-neyens: Support multilingual for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.