To get this theme to full release we need to make sure our code is up to scratch according to the Drupal coding standards.

Using the PAReview tool we've managed to squish a lot of the issues and now it's down to just a few, with the last of the reviews here.

The funny thing with the css "errors" is that the errors it's pointing out don't exist in the file, so I think we can get away with leaving those for now.

What we're left with is a few things in the bones.theme file:

FILE: ...0000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/bones.theme
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 17 | ERROR | [ ] Type hint "array" missing for $variables
 18 | ERROR | [x] Short array syntax must be used to define arrays
 22 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Looks like it would be easiest to use PHPCBF to fix them, like the suggestion says.

Comments

lauramunro created an issue. See original summary.

  • 1d48cf0 committed on 8.x-1.x
    Issue #2977408 by lauramunro, roxflame: Re-apply phpcs and phpcbf...
roxflame’s picture

I've added a commit above, of the changes recommended in phpcs, automatically applied with phpcbf, locally, using Drupal standards from Drupal coder module.
however, the bones.theme file was not affected in the scanning... SO, I'm going to have to review this again and see whats up...
It's possible this commit just makes it messier, we will see

roxflame’s picture

I'm going to retry this with full PAReview installed instead. I think that is whats needed...

  • roxflame committed b9cdb02 on 8.x-1.x
    git commit -m "Issue #2977408 by lauramunro, roxflame: Doing the changes...
roxflame’s picture

Gave up on local install of PAReview, and instead addressed the issues above manually. Will retest

roxflame’s picture

The above listed issues are now sorted :)

Now just back to the non-issues
https://pareview.sh/pareview/https-git.drupal.org-sandbox-thomasmurphy-2...

roxflame’s picture

Status: Active » Fixed

Closing this ticket for now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.