Closed (fixed)
Project:
Bones Theme
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
5 Jun 2018 at 04:45 UTC
Updated:
2 Jul 2018 at 13:29 UTC
Jump to comment: Most recent
To get this theme to full release we need to make sure our code is up to scratch according to the Drupal coding standards.
Using the PAReview tool we've managed to squish a lot of the issues and now it's down to just a few, with the last of the reviews here.
The funny thing with the css "errors" is that the errors it's pointing out don't exist in the file, so I think we can get away with leaving those for now.
What we're left with is a few things in the bones.theme file:
FILE: ...0000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/bones.theme
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
17 | ERROR | [ ] Type hint "array" missing for $variables
18 | ERROR | [x] Short array syntax must be used to define arrays
22 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Looks like it would be easiest to use PHPCBF to fix them, like the suggestion says.
Comments
Comment #3
roxflame commentedI've added a commit above, of the changes recommended in phpcs, automatically applied with phpcbf, locally, using Drupal standards from Drupal coder module.
however, the bones.theme file was not affected in the scanning... SO, I'm going to have to review this again and see whats up...
It's possible this commit just makes it messier, we will see
Comment #4
roxflame commentedI'm going to retry this with full PAReview installed instead. I think that is whats needed...
Comment #6
roxflame commentedGave up on local install of PAReview, and instead addressed the issues above manually. Will retest
Comment #7
roxflame commentedThe above listed issues are now sorted :)
Now just back to the non-issues
https://pareview.sh/pareview/https-git.drupal.org-sandbox-thomasmurphy-2...
Comment #8
roxflame commentedClosing this ticket for now