SerialSQLStorage's constructor is expecting the second parameter as EntityTypeManager instead of EntityTypeManagerInterface.

CommentFileSizeAuthor
#2 2977055-2.patch913 bytesjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 2977055-2.patch913 bytes

Attached is the small change for the interface, this allows devel's webprofiler to wrap it.

singularo’s picture

singularo
Location Adelaide, AUS
commented

I incorporated the changes from this patch in https://www.drupal.org/project/serial/issues/2946075 when re-rolling it.

extexan’s picture

extexan commented

In addition to adding:

use Drupal\Core\Entity\EntityTypeManagerInterface;

...shouldn't this also be removed:

use Drupal\Core\Entity\EntityTypeManager;
extexan’s picture

extexan commented

After applying this patch (and making sure I'm on the latest version of Serial module), I still get the following error:

TypeError: Argument 2 passed to Drupal\serial\SerialSQLStorage::__construct() must be an instance of Drupal\Core\Entity\EntityTypeManager, instance of Drupal\webprofiler\Entity\EntityManagerWrapper given, called in /var/www/html/core/lib/Drupal/Component/DependencyInjection/Container.php on line 273 in Drupal\serial\SerialSQLStorage->__construct() (line 39 of modules/contrib/serial/src/SerialSQLStorage.php).

  • colorfield committed 7d17384 on 8.x-1.x 
    Issue #2977055 by joelpittet, ExTexan, singularo, colorfield: Use...
colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented

Thanks all! I've included comment from #4 and updated based on #3120452: deprecated class QueryFactory. Works fine with latest Devel web profiler.

colorfield’s picture

colorfield
Primary language French
Location Lausanne
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.