I think the page showing the messages of a migration (migrate_tools.messages route) should show the migration label.
Patch will follow

CommentFileSizeAuthor
#5 migrate_tools-migration_messages_page_title-2976741-5.patch1.47 KBsylvainm
#2 migrate_tools-migration_messages_page_title-2976741-2.patch1.82 KBsylvainm

Comments

SylvainM created an issue. See original summary.

sylvainm’s picture

sylvainm commented
Status: Active » Needs review
StatusFileSize
new migrate_tools-migration_messages_page_title-2976741-2.patch1.82 KB

Attached patch provides that title

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work 
+++ w/src/Controller/MessageController.php
@@ -141,4 +142,31 @@ public function overview($migration_group, $migration) {
+    try {
...
+    catch (PluginException $e) {

This shouldn't be needed to wrap in a try/catch. The route will return a 404 well before we get to this. I think. And you should be able to type hint those arguments to the title callback, similar to ::overview.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Issue tags: +Needs reroll

Also, need a re-roll.

sylvainm’s picture

sylvainm commented
Issue tags: -Needs reroll
StatusFileSize
new migrate_tools-migration_messages_page_title-2976741-5.patch1.47 KB

Here is a new patch

sylvainm’s picture

sylvainm commented
Status: Needs work » Needs review
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work 
+++ w/src/Controller/MessageController.php
@@ -141,4 +141,22 @@ public function overview(MigrationGroupInterface $migration_group, MigratePlusMi
+  public function title(MigrationGroupInterface $migration_group, MigratePlusMigrationInterface $migration) {

I think there isn't an interface called MigratePlusMigrationInterface

sylvainm’s picture

sylvainm commented
Status: Needs work » Needs review

This is the alias of Drupal\migrate_plus\Entity\MigrationInterface: https://cgit.drupalcode.org/migrate_tools/tree/src/Controller/MessageCon...

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Reviewed & tested by the community

I see that now. Looks good.

  • heddn committed 76bf9c9 on 8.x-4.x authored by SylvainM 
    Issue #2976741 by SylvainM, heddn: Migration Messages page title missing...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.