Closed (fixed)
Project:
Drupal core
Version:
8.6.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 May 2018 at 15:09 UTC
Updated:
27 Jun 2019 at 18:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
GrandmaGlassesRopeMan- namespace all nightwatch custom commands with
drupalComment #3
GrandmaGlassesRopeManComment #4
dawehnerAs written in slack it feels like the old Simpletest function, which we got rid when moving to phpunit.
On the other hand though, JS doesn't have the namespace advantage of PHP, so I think this is fine.
Comment #5
alexpottCommitted 8aef9a8 and pushed to 8.6.x. Thanks!
Comment #8
MixologicUninstall should have two L's.
Also, not sure what/where/how we decide if this is an API or not. I know of at least one contrib module that had a test that stopped working, probably NBD, as it seems like a difficult thing to balance between "its not really an API yet, because its not in a full stable release", vs "please write nightwatch tests so we can know if theres something missing/needed"
Also we probs ought to have our sample tests at least exercise some of these functions: I opened a followup: #2981308: Ensure nightwatch tests exercise all apis at least once.
Since I cant reopen this, maybe this typo fix could just get rolled into that.
Comment #9
jibranThe latest patch in #3059356: [Security] Update yarn packages to fix 19 vulnerabilities by updating nightwatch is purposing the following change:
We'd love to have someone review the patch.