Problem/Motivation

XLIFF notes contain only a property label. This makes it hard for non-Drupal people to associate where those notes fit in Drupal. This especially affects some translation providers that automatically process XLIFF files.

Proposed resolution

Use a field name + property name in XLIFF notes.

Example:
"Body > Text"

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 improve-xliff-notes-2976573-5-interdiff.txt1.99 KBmbovan
#5 improve-xliff-notes-2976573-5.patch2.61 KBmbovan
#5 improve-xliff-notes-2976573-TEST-ONLY-5.patch1.99 KBmbovan
#2 improve-xliff-notes-2976573-2.patch634 bytesmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new improve-xliff-notes-2976573-2.patch634 bytes

A patch that improves the XLIFF notes by relying on a parent label.

Let's see if we have existing tests for this part.

mbovan’s picture

mbovan commented

#2977229: Fix head tests was committed so triggering the test bot here.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Apparently we're not asserting this right now, at last not on complex structures.

mbovan’s picture

mbovan commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new improve-xliff-notes-2976573-TEST-ONLY-5.patch1.99 KB
new improve-xliff-notes-2976573-5.patch2.61 KB
new improve-xliff-notes-2976573-5-interdiff.txt1.99 KB

I expanded \Drupal\tmgmt_file\Tests\FileTranslatorTest::testXLIFF() with assertions for the note tag.

The last submitted patch, 5: improve-xliff-notes-2976573-TEST-ONLY-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • Berdir committed 0ddedd1 on 8.x-1.x authored by mbovan 
    Issue #2976573 by mbovan: Improve XLIFF notes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Looks good, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.