When the parent has attributes, the simple_xml data_parser migrate_plus plugin reduces single-value results to scalars wrongly: it takes the attributes instead of the value.

Patch will follow

CommentFileSizeAuthor
#2 migrate_plus-fix_simple_xml_reduce_single_value-2976091-2.patch3.25 KBsylvainm
#2 migrate_plus-fix_simple_xml_reduce_single_value-2976091-2-test_only.patch2.66 KBsylvainm

Comments

SylvainM created an issue. See original summary.

sylvainm’s picture

sylvainm commented
Status: Active » Needs review
StatusFileSize
new migrate_plus-fix_simple_xml_reduce_single_value-2976091-2-test_only.patch2.66 KB
new migrate_plus-fix_simple_xml_reduce_single_value-2976091-2.patch3.25 KB

Attached patch fixes that

The last submitted patch, 2: migrate_plus-fix_simple_xml_reduce_single_value-2976091-2-test_only.patch, failed testing. View results

pookmish’s picture

pookmish commented
Status: Needs review » Needs work

Thanks. the patch was exactly the same thing i ended up doing before i searched for this issue.
Putting to NW to get tests to pass.

pookmish’s picture

pookmish commented
Status: Needs work » Reviewed & tested by the community

Oh i just saw the two patches for testing..

  • heddn committed d24565d on 8.x-4.x authored by SylvainM 
    Issue #2976091 by SylvainM, pookmish, heddn: Simple Xml data_parser...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.