Problem/Motivation
Follow up to #2949964: Add an EntityOwnerTrait to standardize the base field needed by EntityOwnerInterface.
The Workspace entity should use EntityOwnerTrait.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2975957-7.patch | 3.12 KB | sam152 |
| #4 | 2975957.patch | 3.26 KB | amateescu |
Comments
Comment #2
sam152 commentedComment #3
sam152 commentedComment #4
amateescu commentedIt's funny that #2949964: Add an EntityOwnerTrait to standardize the base field needed by EntityOwnerInterface was opened from a review of the initial workspace patch, but handling the workspace entity has been left to a followup :)
Anyway, once the parent issue lands, this patch should do it.
Comment #6
amateescu commentedFix component following module rename.
Comment #7
sam152 commentedComment #8
longwaveLooks good to me.
Comment #9
alexpottAs an experimental module backporting to 8.6.x
Committed and pushed 69a3c90ce9 to 8.7.x and 1564d99234 to 8.6.x. Thanks!
Fixed unused use on commit.
Comment #12
tacituseu commentedThis introduced test failures on 8.6.x because #2949964: Add an EntityOwnerTrait to standardize the base field needed by EntityOwnerInterface wasn't backported:
https://www.drupal.org/pift-ci-job/1071807
https://www.drupal.org/pift-ci-job/1071809
Comment #13
longwaveYeah, this needs rolling back from 8.6.x as EntityOwnerTrait is a new feature in 8.7.x only.
Comment #14
alexpottFixed