Character types in character plugin not translatable

Moving to needs review

Thanks for the patch. It applied successfully but it's still not translating for me. I added a new language, enabled configuration translation for password policy, but still see it in english instead of the language I added. See attached screenshot. Is there another step I should be taking?

I have tested the patch and it solved the problem, but this patch do not solve the problem of labels ('at least', 'at most') witch are not translatable on PasswordLength plugin.

I created a new patch (based on translatable_character_types.patch) , to make labels ('at least', 'at most') translatable.

@daniel_rose : after applying the patch you should load Password Policy Constraints summary page: ( Configuration -> Security -> Password Policies -> Configure Constraints), and then on user interface translation, translate theses labels:
- Uppercase, Lowercase, Numeric, Special characters, at least, at most.

Improve the patch code to validate Drupal coding standard.

New patch to validate Drupal coding standard

New patch to validate Drupal coding standard

New patch to validate Drupal coding standard

Works as expected. Thanks for the patch. :)

Updated the patch, the password length check translations (at least, at most) are already implemented.

Setting to "Needs review" so tests are run.

We ran into the same issues, I am attaching a patch that handles translations and formatting for plurals. We tried to use the same method as the status for the constraints. Also added back the "at most" and "at least".

#14 doesn't apply.

Since the bottom half of patch was added just adding this here with it removed.

#17 seems to fix the issue for me. Strings are being translated, as they should be. Thanks.

# 17 seems to fix the issue for me too. Now it is possible to translate the strings.

Why not just to change

  public function getSummary() {
    return $this->t('Password must contain @characters @character-type characters', ['@character-type' => $this->configuration['character_type'], '@characters' => $this->configuration['character_count']]);
  }

to

  public function getSummary() {
    return $this->t('Password must contain @characters @character-type characters', ['@character-type' => t($this->configuration['character_type']), '@characters' => $this->configuration['character_count']]);
  }

?

Patch #17 works well, It fix also singular/plural form. @narres about your patch, it is not good approach to pass variables to the t() function, please check https://www.drupal.org/docs/8/api/translation-api/overview#s-variables-in-user-interface-text

Patch #17 looks good!
I'm re-adding it because the last patch of the issue is the patch that should be committed.

Merging in #17 after my review - thanks all!

Marking as fixed, thanks!