Problem/Motivation

Currently the payment gateways are hardcoded. See commerce_pos_reports_get_payment_gateway_options(). The module should support other payment gatewayss enabled in the site.

This restricts the EOD report. If an order has been paid via any other payment gateway, it does not shows up in the report.

Proposed resolution

The payment gateways should be loaded dynamically.

Remaining tasks

Not sure but I think #2738915: Add better support for Commerce payment methods is same as this problem. The issue belongs to 7.x. Should the fix be made as part of that issue and we close this one?

User interface changes

The EOD report is going to show all payment gateways.

API changes

commerce_pos_reports_get_payment_gateway_options() will now dynamically load all enabled payment gateways.

Data model changes

N/A

CommentFileSizeAuthor
#2 2975396-2.patch1.14 KBsubhojit777

Comments

subhojit777 created an issue. See original summary.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Active » Needs review
StatusFileSize
new 2975396-2.patch1.14 KB
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Title: Unhardcode payment gateway gateways » Unhardcode payment gateways
jnrfred’s picture

jnrfred commented
Status: Needs review » Reviewed & tested by the community

Patch works fine.

smccabe’s picture

smccabe commented
Status: Reviewed & tested by the community » Fixed

Committed, thnx guys!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.