Pareview report show some php error in the splash_screen.install, SplashScreenBlock.php and CustomredirectSubscriber.php file.

See the attached files.

CommentFileSizeAuthor
#5 splash-screen-2975262-5.patch9.13 KBishani.addweb
#3 2018-10-26 10_44_33-MINGW64__c_xampp_htdocs_drupal_modules_splash_screen.png18.2 KBakshay kashyap
#2 splash-screen-2975262-2.patch9.12 KBishani.addweb
SplashScreenBlock.png205.96 KBbandanasharma
CustomredirectSubscriber.png89.96 KBbandanasharma

Comments

bandanasharma created an issue. See original summary.

ishani.addweb’s picture

ishani.addweb commented
Status: Active » Needs review
StatusFileSize
new splash-screen-2975262-2.patch9.12 KB

@bandanasharma, Please find my attached patch, that resolves the same standard errors mentioned or shown in Pareview. Hope this helps you.

akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new 2018-10-26 10_44_33-MINGW64__c_xampp_htdocs_drupal_modules_splash_screen.png18.2 KB

@Ishani.addweb thanks for the work when I have applied your patch it gives some warning messages. I have attached the screenshot for reference. your patch changes reflect on splash_screen.install file other two files need to work so please work on it.

bandanasharma’s picture

bandanasharma commented
Status: Needs review » Needs work
ishani.addweb’s picture

ishani.addweb commented
Status: Needs work » Needs review
StatusFileSize
new splash-screen-2975262-5.patch9.13 KB

@Akshay kashyap, Thanks for reviewing my patch, I reviewed your comment & try to resolve the issue you are facing. Kindly review the newly attached one & feel free to share your feedback.

Thanks!..

arunkumarkit’s picture

arunkumarkit commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.