The withdrawal tab covers elements behind it. We should position it absolutely so that it only covers the area needed.

CommentFileSizeAuthor
#8 eu_cookie_compliance-withdrawal-tab-covers-elements-behind-it-2974996-8-7.x.patch4.15 KBsvenryen
#5 eu_cookie_compliance-withdrawal-tab-covers-elements-behind-it-2974996-5.patch4.05 KBsvenryen
#2 2974996-withdrawal-tab-absolute-2.patch2.98 KBluksak

Comments

Lukas von Blarer created an issue. See original summary.

luksak’s picture

luksak
he/him
commented
Status: Active » Needs review
StatusFileSize
new 2974996-withdrawal-tab-absolute-2.patch2.98 KB

The patch positions the tabl absolutely and simplyfies the calculations for the animation in javascript.

svenryen’s picture

svenryen commented
Assigned: luksak » Unassigned
svenryen’s picture

svenryen commented

The patch needs work.
- The css is included only for the bare css version
- The tab disappears when pinned to the top

This should be fixed before the next release is tagged, as it's a showstopper. I'll see what I can come up with. Thanks for the patch.

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-withdrawal-tab-covers-elements-behind-it-2974996-5.patch4.05 KB

I resolved both issues. The same css could be used for both files, and it was easy to fix the top positioned tab.

Here's an updated patch.

  • svenryen committed 079d372 on 8.x-1.x 
    Issue #2974996 by Lukas von Blarer, svenryen: Withdrawal tab covers...

Status: Needs review » Needs work

The last submitted patch, 5: eu_cookie_compliance-withdrawal-tab-covers-elements-behind-it-2974996-5.patch, failed testing. View results

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-withdrawal-tab-covers-elements-behind-it-2974996-8-7.x.patch4.15 KB

Not sure why it failed to apply.

Here's the patch for D7.x

svenryen’s picture

svenryen commented
Status: Needs work » Fixed

  • svenryen committed 5d23302 on 7.x-1.x 
    Issue #2974996 by svenryen, Lukas von Blarer: Withdrawal tab covers...

  • svenryen committed 5d23302 on 7.x-2.x 
    Issue #2974996 by svenryen, Lukas von Blarer: Withdrawal tab covers...
  • svenryen committed 884a355 on 7.x-2.x
    Merge branch '7.x-1.x' into 7.x-2.x

* 7.x-1.x:
Issue #2975382 by...
tr-drupal’s picture

tr-drupal commented

I've just updated to eu_cookie_compliance-7.x-1.24 and the patches from here seem to be apllied there as well, but it's still not working for me.

If banner position is "top" and I click "agree" button, then the "privacy settings tab" is visible for a second at the top and then disappears. It's only present permanently, if the position of the banner is "bottom". Happening on a page with fixed area at the top, which remains there even when scrolling, which is why this one was added to the module some time ago (Use position:fixed for the banner when displayed at the top.), in case it matters.

svenryen’s picture

svenryen commented

Thanks, will take a look tonight. Sorry that the release was rushed due to the security issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tr-drupal’s picture

tr-drupal commented

Hello, this issue (comment #12) still exists with 7.x-1.25
Small addition: the tab disappears straight after giving consent. One I load another page, the tab is and remains there.