I have several content types that have their configuration tracked by the Features module. After installing the svg_image module all of my Image fields now report that the displays aren't using the image module formatter, but rather the one defined in svg_image and have extra settings defined relating to SVG image/width.
The issue here is that this module alters core's image field formatter display instead of creating its own.
Breaking Change: Image field displays that support SVG will need to change their display formatter to Image (SVG Support).
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2957476-3-implement-hook-field-formatter-info.patch | 987 bytes | dasginganinja |
Comments
Comment #2
dasginganinjaAfter looking at this for a bit and thinking about how to approach a patch, it seem that it would it make more sense to define a separate field formatter for this module instead of hijacking core's version.
I think the other modifications of the core image field are fine, but this could be implemented in a different manner that doesn't alter existing configurations.
Comment #3
dasginganinjaI have created a patch which copies core's image field formatter information and alters it as it was being used in this module.
After this change, a new image formatter is available titled Image (SVG Support).
The core Image display formatter will still not support SVG with this patch, but that is to be expected. There is already a core issue where bringing SVG support to D7 is being discussed. This module should focus on providing a display instead of altering core's.
This is a "breaking" change for those who expect the core image formatter to support SVG, but since the module is still is in development and doesn't have a 7.x release that shouldn't be a big issue.
Comment #4
dasginganinjaComment #5
imyaro commentedAgree with you, commited. Thanks for your contribution.
Comment #7
imyaro commentedAvailable in release 7.x-1.1