I'm developing a application that doesn't require the node module, when you disable the node module the Goto/search function of this module breaks. I get this error on every page request:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "node_type" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 133 of /core/lib/Drupal/Core/Entity/EntityTypeManager.php).

Drupal core version: 8.5.3

CommentFileSizeAuthor
#3 coffee-node-module-disbled-2973864-3.patch1.5 KBmitsuroseba

Issue fork coffee-2973864

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Wemagine created an issue. See original summary.

sander wemagine’s picture

sander wemagine commented
Issue summary: View changes
mitsuroseba’s picture

mitsuroseba commented
Status: Active » Needs review
Issue tags: +DevDaysLisbon
StatusFileSize
new coffee-node-module-disbled-2973864-3.patch1.5 KB

Added additional check.

keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community

Patch #3 working fine.

willzyx’s picture

willzyx commented
Status: Reviewed & tested by the community » Needs work

@mitsuroseba thanks for contributing!
Can we add test coverage for this change? Thanks

sander wemagine’s picture

sander wemagine commented

Patch #3 works for me. Thank you mitsuroseba

paul121 made their first commit to this issue’s fork.

paul121 opened merge request !4

paul121’s picture

paul121 commented
Status: Needs work » Reviewed & tested by the community

Patch #3 works great.

I took a pass at adding tests but see that none of the test runners are enabled for this project right now. IMO it would be great to merge this fix in even without tests because it is a simple change and unnecessary that this requires the node module.