Closed (fixed)
Project:
EU Cookie Compliance (GDPR Compliance)
Version:
7.x-1.19
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
17 May 2018 at 21:18 UTC
Updated:
2 Feb 2019 at 15:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
svenryen commentedWait, are you talking about certain links that when clicked shouldn't trigger a consent, or consent exclusion for all links on entire pages?
Do you have an example where this happens, or steps to reproduce? The module itself has ajax requests, but they don't trigger a consent. (And can you agree that we should open a separate issue on this?)
Comment #3
khaldoon_masud commentedI am talking about certain links that when clicked shouldn't trigger a consent. example, I am displaying the links of our privacy policy and terms pages in the banner message.
"By continuing to use our site and services, you agree to our use of cookies, our revised [Privacy Policy], and our [Terms of Service]."
But when visitor clicks privacy policy or terms link in the banner, it auto accepts the cookie.
Comment #4
svenryen commentedI have an idea for this. What if we came up with a class selector that when applied to links caused the clicks to bypass the "click to agree"/consent function in the JS?
Would that be sufficient for you if it's properly documented? It's a quick fix and this solution wouldn't add additional clutter in the admin interface.
I'm changing the issue title and description to match your answer in #3.
I also created issue #2973925: Some pages use click actions triggered by javascript and the module consider it as a consent.. Please follow up with steps to reproduce the ajax issue.
Comment #5
khaldoon_masud commentedI like the solution. Thanks for doing it.
Comment #6
khaldoon_masud commentedAny idea when can I get this patch #4?
Comment #7
svenryen commented@khaldoon_masud - to explain something: I'm currently spending all available spare time working on several issues that are required by the new GDPR legislation. Thank you for following up, you can get this patch from me in late June, July or August. You're also welcome to either provide a patch yourself or ask any colleagues/friends to help out.
Comment #8
khaldoon_masud commentedI am working on the patch then. Thanks!
Comment #9
adamps commentedHere is a simple patch that excludes any clicks on the banner message - this would cover #3 with even needing to add new classes to links.
Comment #10
svenryen commentedThanks for the patch, looks good. I'll take a look later. Due to a birthday out of town this weekend, it will probably be mid August before I can get this committed.
Comment #11
adamps commentedSure, many thanks, have a great weekend
Comment #12
adamps commentedPatch in #9 is bad. Here is a working version with patches for D7/D8.
Comment #14
svenryen commentedNot sure if it also works for "a href" links in the banner? The "not" seems applied only to buttons?
Comment #15
adamps commentedIt works for me on links - NB there is an 'a' at the start of that selector. The patch doesn't change the selector, it just adds the not.
$('a, input[type=submit], button[type=submit]').not('.popup-content *').bind('click.euCookieCompliance',
Comment #16
svenryen commentedSorry, misread. You're right.
Comment #17
svenryen commentedThanks for the patch. It's likely this will make it into the module soon, as there's both a D7 and D8 patch.
Comment #18
svenryen commentedThanks for the patch. Reviewed and tested, all well.
I added a notice to the README.txt about this feature, as it's not obvious without combing through the entire javascript file.
Updated patches attached and committed.
Comment #21
svenryen commentedComment #23
adamps commentedGreat many thanks @svenryen