Problem/Motivation

Yesterday #2972003: Verify that the file name matches the ID when installing configuration was committed to Drupal Core. This commit is causing Drupal\Tests\search_api\Kernel\System\FieldValuesExtractionTest to fail.

Proposed resolution

Fix the automated test failure.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 2973047-3--misnamed_test_config_file.patch874 bytesdrunken monkey
#3 2973047-3--misnamed_test_config_file--interdiff.txt1.45 KBdrunken monkey
#2 search_api-automated_test_failure-2973047-2.patch2.69 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new search_api-automated_test_failure-2973047-2.patch2.69 KB

Attached patch fixes the automated test failure by updating the configuration file name and updating its id to match.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: General code » Tests
Priority: Normal » Major
StatusFileSize
new 2973047-3--misnamed_test_config_file--interdiff.txt1.45 KB
new 2973047-3--misnamed_test_config_file.patch874 bytes

Thanks a lot for reporting this issue and already providing a patch!
I am pretty certain the old IDs were correct though, we just needed to adjust the file names (which we apparently forgot in #2758475: Replace entity_test by entity_test_mulrev_changed throughout kernel tests).
See the attached patch revision.
That your test actually passes, with a wrong ID, is actually a bit worrisome. If I'm right and my patch passes, too, I guess I'll notify the Core issue about this.

Status: Needs review » Needs work

The last submitted patch, 3: 2973047-3--misnamed_test_config_file.patch, failed testing. View results

  • drunken monkey committed 4865aa2 on 8.x-1.x authored by idebr 
    Issue #2973047 by idebr, drunken monkey: Fixed misnamed test config...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Huh. Seems like this is a test bot bug (cf. #2973992: Permission issue in Nightwatch step marks all full testruns as unstable), the tests passed if you look at the complete result.
So: committed.
Thanks again for your help!

As I said I would, I also commented on the Core issue about the passing patch #2: #2972003-14: Verify that the file name matches the ID when installing configuration.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.