Problem/Motivation

\Drupal\Tests\search_api\Kernel\BasicTrackerTest has an outdated @todo:

// @todo Change to createMock() once we depend on Drupal 8.5+. See #2930839.

The code was updated in #2930839: Update tests according to latest PHPUnit compatibility changes and the version requirement was raised in #2961537: Increase Core dependency to Drupal 8.5

Proposed resolution

Remove the outdated @todo from the code base.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 search_api-remove_outdated_todo-2973034-2.patch1.09 KBidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new search_api-remove_outdated_todo-2973034-2.patch1.09 KB

Attached patch removes the outdated @todo from the code base.

Status: Needs review » Needs work

The last submitted patch, 2: search_api-remove_outdated_todo-2973034-2.patch, failed testing. View results

  • drunken monkey committed 5a06192 on 8.x-1.x authored by idebr 
    Issue #2973034 by idebr, drunken monkey: Removed outdated @todo comment.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Thanks, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.