One of our clients wanted the ability to limit the size of the files which could be uploaded in the quiz questions.
I created a patch for this. Was a bit surprised that this functionality was not already in the module.
The default upload limit is set to 15MB.
Upload limit can be set on the admin config page: admin/quiz/settings/questions_settings
And can be overridden on the node edit page.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | quizfileupload-Add_ability_to_limit_upload_filesize-2973014-9.patch | 7.84 KB | da_cloud |
| #3 | add_ability_to_limit_upload_filesize_2973014-3.patch | 5.4 KB | johan den hollander |
Comments
Comment #2
johan den hollander commentedComment #3
johan den hollander commentedPrevious patch included something not related to the functionality in this issue.
(Allowed extension vs Allowed extensions).
I will create a new issue for this.
Comment #4
da_cloud commentedComment #6
da_cloud commentedSeems like a nice feature to add to the module. The patch itself looks fine as well, but 2 minor things come to mind.
1) The tests are currently failing because its missing the new database field during install. The changes made in the new hook_update are missing within quizfileupload_schema.
2) In terms of the default upload limit I would personally prefer to follow the same logic as the file upload module itself. It seems to work using a combination of file_upload_max_size() to determine a sensible default based on the server settings and parse_size() to allow the user to fill in various size indicators (instead of forcing on only MB).
Comment #7
da_cloud commentedI've reworked the patch to be more inline with how the file module handles the max filesize.
Comment #9
da_cloud commentedFixed some of the test cases.
Comment #11
da_cloud commentedComment #12
johan den hollander commented@Da_Cloud We tested the latest dev version, with this functionality included. It works as expected. Thank you for improving the initial patch.