Closed (fixed)
Project:
Salesforce Marketing Cloud API Integration
Version:
8.x-1.x-dev
Component:
Documentation
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 May 2018 at 23:40 UTC
Updated:
17 May 2018 at 06:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bandanasharma commentedAdded the patch. Please review.
Comment #3
msankhala commentedAdding single quote shouldn't be part of this patch. All the submodule do not have these single quote around 'title' and 'description'. To maintain consistency it should not have the single quote around these.
@john_a Just a suggestion rather than having multiple issues just to add a newline at the end of different files. Why not have a single issue to address all the missing newline in different files. This will reduce the work and we could have avoided
#2972837: marketing_cloud_interaction README.md newline at end of file
#2972883: marketing_cloud_platform README.md missing newline
#2972894: marketing_cloud_messages/README.md doc missing newline
#2972890: marketing_cloud_contacts/README.md doc mossing newline
#2972905: marketing_cloud_data_events/README.md missing newline
#2972901: marketing_cloud_sms/README.md missing newline
Comment #4
john_a commented@msankhala, thanks for the suggestion, you have a fair point. noted for next time a similar situation crops up.
Comment #5
bandanasharma commentedRemove the single quote and again upload the patch.
Comment #6
msankhala commented@bandanasharma The patch #5 looks good and i confirm this applies cleanly.
Comment #7
msankhala commentedComment #8
john_a commentedThanks @all, patch ported to the dev branch.
Comment #9
john_a commentedComment #10
john_a commented