The marketing_cloud_example.links.menu.yml does not have a newline at the end of the file.

See attached txt file for the Pareview report.

Comments

john_a created an issue. See original summary.

bandanasharma’s picture

Status: Active » Needs review
StatusFileSize
new784 bytes

Added the patch. Please review.

msankhala’s picture

Status: Needs review » Needs work
+++ b/modules/marketing_cloud_example/marketing_cloud_example.links.menu.yml
@@ -1,5 +1,5 @@
+  title: 'Marketing Cloud Example'
+  description: 'An example of a webform with a custom plugin using the marketing_cloud module.'

Adding single quote shouldn't be part of this patch. All the submodule do not have these single quote around 'title' and 'description'. To maintain consistency it should not have the single quote around these.

@john_a Just a suggestion rather than having multiple issues just to add a newline at the end of different files. Why not have a single issue to address all the missing newline in different files. This will reduce the work and we could have avoided
#2972837: marketing_cloud_interaction README.md newline at end of file
#2972883: marketing_cloud_platform README.md missing newline
#2972894: marketing_cloud_messages/README.md doc missing newline
#2972890: marketing_cloud_contacts/README.md doc mossing newline
#2972905: marketing_cloud_data_events/README.md missing newline
#2972901: marketing_cloud_sms/README.md missing newline

john_a’s picture

@msankhala, thanks for the suggestion, you have a fair point. noted for next time a similar situation crops up.

bandanasharma’s picture

Status: Needs work » Needs review
StatusFileSize
new650 bytes

Remove the single quote and again upload the patch.

msankhala’s picture

Status: Needs review » Reviewed & tested by the community

@bandanasharma The patch #5 looks good and i confirm this applies cleanly.

msankhala’s picture

john_a’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

Thanks @all, patch ported to the dev branch.

john_a’s picture

Status: Patch (to be ported) » Fixed
john_a’s picture

Status: Fixed » Closed (fixed)