Currently the warning message displayed when your password is expired is not translatable.

It would be nice to have it translatable for multilingual sites.

CommentFileSizeAuthor
#13 password_policy-7.x-2.x-make_expire_warning_message_translatable-2972655-13.patch678 bytesaohrvetpv
#4 password_policy-7.x-2.x-translatable_expired_password_message-2972655-4.patch519 bytesaohrvetpv
#2 password_policy-translatable_expired_password_message-2972655-2.patch1.18 KBpaulvandenburg

Comments

paulvandenburg created an issue. See original summary.

paulvandenburg’s picture

paulvandenburg commented
Status: Active » Needs review
StatusFileSize
new password_policy-translatable_expired_password_message-2972655-2.patch1.18 KB

This makes the message translatable.

ruudvanoijen’s picture

ruudvanoijen commented

Patch looks good.

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-7.x-2.x-translatable_expired_password_message-2972655-4.patch519 bytes

I don't think we need to mention that the message is translatable. There are many other strings that are translatable in this module and in Drupal, and it is not mentioned, so this seems consistent. (Or maybe there is precedent for mentioning a string is translatable?)

So this patch removes "This message is translatable." I will commit if this is OK. Thanks.

paulvandenburg’s picture

paulvandenburg commented

Yes that looks good to me.
I mostly added the message since not everything was/is translatable, although it is easy enough to find out if such a setting is translatable.

aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

Thanks. Are there other strings that need to be made translatable?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

paulvandenburg’s picture

paulvandenburg commented

Not for my use case at the moment. I'll open another issue if such a case does turn up.

aohrvetpv’s picture

aohrvetpv commented
Status: Closed (fixed) » Needs work

The committed change seems to violate coding standards:

FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/plugins/item/expire.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 285 | WARNING | Only string literals should be passed to t() where
     |         | possible
--------------------------------------------------------------------------

Planning to revert.

aohrvetpv’s picture

aohrvetpv commented

Would it work to instead pass the string literal on expire.inc:15 to t()?

  • AohRveTPV committed 668e842 on 7.x-2.x 
    Revert "Issue #2972655 by paulvandenburg: Translatable expired password...
aohrvetpv’s picture

aohrvetpv commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-7.x-2.x-make_expire_warning_message_translatable-2972655-13.patch678 bytes

Not immediately sure how to test that this works. Maybe someone else on this issue could review/test.

paulvandenburg’s picture

paulvandenburg commented

I've not test it yet, but the patch looks good. I think that is a fine solution to the problem.

  • AohRveTPV committed 2f118aa on 7.x-2.x 
    Issue #2972655 by AohRveTPV, paulvandenburg: Translatable expired...
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

Presumed fixed. Please reopen if not.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.