See the change record: Use mb_* functions instead of Unicode::* methods.

CommentFileSizeAuthor
#4 replace-unicode-mb-string-equivalent-2972510-3.patch12.8 KBmsankhala
#3 remove-deprecated-2047119-12.patch1.73 KBmsankhala

Comments

drunken monkey created an issue. See original summary.

msankhala’s picture

msankhala commented
Assigned: Unassigned » msankhala

Working on it.

msankhala’s picture

msankhala commented
Status: Active » Needs review
StatusFileSize
new remove-deprecated-2047119-12.patch1.73 KB

Here is the first version of the patch. There is a Unicode::truncateBytes() function. Should that be replaced by mb_strcut? or there is other equivalent function? Because nothing is mentioned about Unicode::truncateBytes() in change recrod mentioned in issue descriptoin.

Are we trying to remove the dependency from Drupal\Component\Utility\Unicode completely? There is one constants Unicode::PREG_CLASS_WORD_BOUNDARY Is this supposed to be removed as well?

msankhala’s picture

msankhala commented
StatusFileSize
new replace-unicode-mb-string-equivalent-2972510-3.patch12.8 KB

Aah! my bad. Uploaded the wrong patch. Here is correct one.

The last submitted patch, 3: remove-deprecated-2047119-12.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 4: replace-unicode-mb-string-equivalent-2972510-3.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Fixed

Great, thanks a lot!
The patch looks perfect as it is, just replaced one remaining "Unicode::" in a comment and then committed.
As truncateBytes() and PREG_CLASS_WORD_BOUNDARY were not deprecated, we don't want to replace them, so that was correct, too.
Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.