The access check for our "Execute pending tasks" action/route uses a special _search_api_tasks tag for triggering our custom ExecuteTasksAccessCheck service for checking the access (i.e., whether there even are any tasks).
As I've now read (and probably suspected before), this is way too complicated. We should refactor this to just use an access method on the controller itself, referenced with _custom_access in the router definition, and get rid of the separate service.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | search_api-execute_tasks_access-2971619-3.patch | 4.42 KB | idebr |
Comments
Comment #2
idebr commentedAttached patch refactors access to the
search_api.execute_tasksroute to a_custom_accesscallback on the Controller.Comment #3
idebr commentedComment #5
drunken monkeyThanks, looks good!
Committed and created #3004270: Use the "search_api_task_list" cache tag for the "Execute pending tasks" local action access check as a follow-up.