Closed (fixed)
Project:
CAPTCHA Riddler
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 May 2018 at 06:34 UTC
Updated:
1 Sep 2018 at 21:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
msankhala commented@sgoelz This patch does not apply well on 7.x-1.x branch of this module.
Looks like you have a manually downloaded version of this module, not the git clone of this version from https://www.drupal.org/node/142475/git-instructions/7.x-1.x/nonmaintainer
Comment #3
sgoelz commented@msankhala Thanks for the information. I cloned the repository and created a new patch.
Comment #4
msankhala commented@sgoelz new patch looks good and applies cleanly. Only one small chance. According to the Drupal coding standard, each file should has single newline at the end of the file.
See https://www.drupal.org/docs/develop/standards/coding-standards#indenting
Missing single newline at end of the file.
Comment #5
sgoelz commentedThanks for your patience and the information @msankhala
I modified the patch and added a new line at the end of the file.
Comment #6
msankhala commentedHi @sgoelz Thanks for the updated patch and having patience with all my input.
Looks like you added two newlines at the end of file. It should be exactly one newline otherwise git shows warning when applying the patch. See below
On another note the patch file name should follow this convention
[project_name]-[short-description]-[issue-number]-[comment-number].patchSometime people skips the[project_name]or[short-description]or both. So for your next patch the patch name should be something likeconfiguration-path-info-file-2971545-7.patchIf the file has a single newline at the end of file git diff will not show that line. If it has two newlines it will show that.
Comment #7
alex_optimSgoelz, Msankhala, Thanks for our work.
I updated patch. Please check.
Comment #8
msankhala commentedThe patch #7 applies cleanly. Thanks @alex_optim for the fix.
Comment #9
pifagor+1
Comment #10
pifagorComment #11
alex_optimComment #13
alex_optim