Problem/Motivation

This change: https://www.drupal.org/node/2850048

..deprecates a bunch of drupal/core-unicode that we use in favor of the Symfony polyfils.

This is in Drupal core 8.6.x, which Examples currently does not support.

We'll need to follow those deprecations.

Proposed resolution

Wait until the release of Drupal 8.6.0.

Fix usages of Unicode methods that are now deprecated.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 2971229_6.patch2.12 KBMile23
#4 2971229_4.patch0 bytesMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23 created an issue. See original summary.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Issue summary: View changes
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Parent issue: » #2992455: [meta] 8.7.0 deprecation changes
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Active » Needs review
FileSize
2971229_4.patch0 bytes

Removed Unicode references.

Status: Needs review » Needs work

The last submitted patch, 4: 2971229_4.patch, failed testing. View results

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs work » Needs review
FileSize
2971229_6.patch2.12 KB

Better patch.

  • Mile23 committed 93a3208 on 8.x-1.x 
    Issue #2971229 by Mile23: Evaluate Unicode, mb_* usages after 8.6.x...
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Fixed

Even though it seems to have disappeared, the 8.5.x test result passes, and the 8.6.x test does not throw any Unicode-based deprecation errors.

So here we go. Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.