In my stupidity, I saw this output:

One time login url: <http://127.0.0.1:8890/user/reset/1/1525471291/YDs8yfQOMeXtO9i6_AVVFBbkPmLImvVb-5Wctg4bb5Q/login>
Press Ctrl-C to quit.

... and assumed it was instructing me to click the link, then hit Ctrl-C to end the quick start process.

I also was in #contribute and asked "hey how do I kill the server when I'm done so it's not eating up resources?"

So, basically:

  1. I hit Ctrl+C thinking it was the last part of the script's process.
  2. I killed my server without realizing it.
  3. And nowhere along the way did I realize Ctrl+C was how I was meant to kill the server.

Something more along the lines of The server is running. Press Ctrl-C to terminate it. would have prevented this (for me, at least).

CommentFileSizeAuthor
#7 2969718-2.patch847 bytesruneasgar
#3 2969718-1.patch862 bytesruneasgar

Comments

runeasgar created an issue. See original summary.

runeasgar’s picture

runeasgar commented
Issue summary: View changes
runeasgar’s picture

runeasgar commented
Status: Active » Needs review
StatusFileSize
new 2969718-1.patch862 bytes

I made a patch :D figures the first issue that's simple enough for me to patch myself, is an issue I filed myself.

I also tested it. The new text is:

The Drupal development server is running. Press Ctrl-C to stop it.

I tried to keep it close to other terminology that is already used in the output.

geerlingguy’s picture

geerlingguy commented
Status: Needs review » Reviewed & tested by the community

Assuming tests pass. Better UX for those who might not be used to running servers in the foreground via the CLI.

dawehner’s picture

dawehner
Primary language German
commented
Category: Feature request » Task

Thank you for the improvement!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/lib/Drupal/Core/Command/ServerCommand.php
@@ -219,7 +219,7 @@ protected function start($host, $port, DrupalKernelInterface $kernel, InputInter
+    $io->writeln('The Drupal development server is running. Press Ctrl-C to stop it.');

This is duplicating one of lines above which the paste from the issue summary doesn't include, ie. Drupal development server started:
I think that changing this to
Press Ctrl-C to quit the Drupal development server. would be better. Less words and less repetitive.

runeasgar’s picture

runeasgar commented
Status: Needs work » Needs review
StatusFileSize
new 2969718-2.patch847 bytes

I'm personally partial to the term "stop" when it comes to shutting down a server process, but here's a patch with your exact wording :p

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

#6 is resolved with the patch in #7. I agree with @alexpott that this is clear enough.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I agree that services are stopped. But this is not a service - it is something running in the foreground and those are quit. The original was also an exact copy what you see when using the in-built PHP webserver interactively so I think it is fair to continue to copy their language.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Committed 0652f65 and pushed to 8.6.x. Thanks!

  • alexpott committed 0652f65 on 8.6.x 
    Issue #2969718 by runeasgar, alexpott: The quick-start script could make...
runeasgar’s picture

runeasgar commented

Makes sense, thanks for clarifying.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.