Problem/Motivation

Custom radio buttons without label are currently hidden in the markup. This becomes obvious with Diff module enabled on the "Revisions" overview page rendered with bs_base.

Screenshot:

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 2969609-hidden-radio-buttons-without-label-11-interdiff.txt517 bytessasanikolic
#11 2969609-hidden-radio-buttons-without-label-11.patch797 bytessasanikolic
#9 2969609-hidden-radio-buttons-without-label-9-interdiff.txt579 bytessasanikolic
#9 2969609-hidden-radio-buttons-without-label-9.patch1.28 KBsasanikolic
#8 Screenshot 2019-03-05 at 17.36.48.png165.8 KBsasanikolic
#5 2969609-hidden-radio-buttons-without-label-5.patch1.22 KBsasanikolic
#3 2969609-hidden-radio-buttons-without-label.patch5.64 KBsasanikolic
Screen Shot 2018-05-04 at 17.11.58.png116.56 KBmbovan

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan commented
Issue summary: View changes

Updated the IS to clarify that given example happens with Diff module enabled. :)

sasanikolic’s picture

sasanikolic commented
StatusFileSize
new 2969609-hidden-radio-buttons-without-label.patch5.64 KB

Here is a patch with the fix.

sasanikolic’s picture

sasanikolic commented
Status: Active » Needs review
sasanikolic’s picture

sasanikolic commented
StatusFileSize
new 2969609-hidden-radio-buttons-without-label-5.patch1.22 KB

Somehow extra compiled stuff got into the patch. Removed those now.

pivica’s picture

pivica commented
Status: Needs review » Needs work

Looks good, please can you provide a screenshot also?

> Somehow extra compiled stuff got into the patch. Removed those now.

Feel free to remove this, we compile bs_bootstrap CSS only when we create a new release.

pivica’s picture

pivica commented 
+++ b/themes/bs_bootstrap/sass/components/partials/_forms.scss
@@ -337,8 +337,17 @@ details {
+      // Display custom inputs if it has no label.

Can we get this comment more verbose so we note exactly why we are doing this and what problem we are solving?

sasanikolic’s picture

sasanikolic commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot 2019-03-05 at 17.36.48.png165.8 KB

Providing the screenshot after the change.

sasanikolic’s picture

sasanikolic commented
StatusFileSize
new 2969609-hidden-radio-buttons-without-label-9.patch1.28 KB
new 2969609-hidden-radio-buttons-without-label-9-interdiff.txt579 bytes

And here is the patch with the improved comment.

pivica’s picture

pivica commented
Status: Needs review » Needs work 
+++ b/themes/bs_bootstrap/css/components/forms.css
@@ -1023,6 +1023,12 @@ details[open] > summary::before {
+.custom-control-input:only-child {
...
+}

Feel free to remove this, as explained in previous comment - we compile bs_bootstrap only on point releases.

sasanikolic’s picture

sasanikolic commented
Status: Needs work » Needs review
StatusFileSize
new 2969609-hidden-radio-buttons-without-label-11.patch797 bytes
new 2969609-hidden-radio-buttons-without-label-11-interdiff.txt517 bytes

Oh sorry, removed that now.

pivica’s picture

pivica commented
Status: Needs review » Reviewed & tested by the community

Perfect, ready to be committed in next point release.

pivica’s picture

pivica commented
Issue tags: +next-point-release-merge

  • pivica committed fa0ca33 on 8.x-1.x authored by sasanikolic 
    Issue #2969609 by sasanikolic, mbovan, pivica: Radio buttons without...
pivica’s picture

pivica commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -next-point-release-merge

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.