CommentFileSizeAuthor
#6 short array 1.png2.12 MBriddhi.addweb
#5 2969435-5.patch11.95 KBbhanuprakashnani
#2 short-array-1.patch3.62 KBimshivani

Comments

imshivani created an issue. See original summary.

imshivani’s picture

imshivani commented
Status: Active » Needs review
StatusFileSize
new short-array-1.patch3.62 KB

I have converted array() to [] as per new coding standards. Attached is the patch for the same.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Needs work

Tested the patch and it applies cleanly, but I think you forgot the array() in .drush.inc file.

marvil07’s picture

marvil07 commented
Related issues: +#2966271: Fix Drupal coding stndard issues

This is probably a subset of the mostly-automated fixed from code sniffer on #2966271: Fix Drupal coding stndard issues.
Attribution for this ticket may be added on the other ticket too.

bhanuprakashnani’s picture

bhanuprakashnani commented
Assigned: Unassigned » bhanuprakashnani
Status: Needs work » Needs review
StatusFileSize
new 2969435-5.patch11.95 KB

I have taken care of all the array syntaxes. Please review and mention if any more changes are to be made. Thank you.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new short array 1.png2.12 MB

@bhanuprakashnani, Thanks for providing patch, your patch clears all the short array errors shown in pareview report. PFA

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
bhanuprakashnani’s picture

bhanuprakashnani commented

Can someone give the fixed tag to this issue?

imshivani’s picture

imshivani commented

@bhanuprakashnani it can be done by the mentors of this module.

  • pifagor committed 6e18bb1 on 8.x-3.x 
    Issue #2969435 by imshivani, bhanuprakashnani, riddhi.addweb: Use Short...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Reviewed & tested by the community » Fixed
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Assigned: bhanuprakashnani » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.