Problem/Motivation

Drupal coding standard issues

FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/Tests/VoteTest.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 118 | WARNING | There must be no blank line following an inline comment
--------------------------------------------------------------------------


FILE: ...or/drupal/pareviewsh/pareview_temp/src/VoteResultFunctionManager.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
  88 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
  94 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
 137 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
--------------------------------------------------------------------------


FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/votingapi.api.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
  54 | WARNING | There must be no blank line following an inline comment
  64 | WARNING | There must be no blank line following an inline comment
  66 | WARNING | Unused variable $aggregate.
  67 | WARNING | Variable $result is undefined.
  67 | WARNING | Variable $result is undefined.
 147 | WARNING | Class name must be prefixed with the project name
     |         | "Votingapi.info"
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/votingapi.drush.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 157 | WARNING | Unused variable $data.
--------------------------------------------------------------------------


FILE: ...h/pareview_temp/tests/modules/votingapi_test/votingapi_test.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 7 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
 8 | WARNING | All dependencies must be prefixed with the project name,
   |         | for example "drupal:"
--------------------------------------------------------------------------

Time: 1.16 secs; Memory: 6Mb

https://pareview.sh/pareview/https-git.drupal.org-project-votingapi.git

Proposed resolution

Resolve all the coding standard issues.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2966271-2.patch47.68 KBmarvil07

Comments

arunkumark created an issue. See original summary.

marvil07’s picture

marvil07 commented
Status: Active » Needs review
StatusFileSize
new 2966271-2.patch47.68 KB

I have regenerated the latest auto-fixes by code sniffer based on the latest test run to made them a git patch.

I only excluded one hunk that looked as false positive:

--- src/Annotation/VoteResultFunction.php
+++ PHP_CodeSniffer
@@ -43,7 +43,7 @@
    *
    * @ingroup plugin_translatable
    *
-   * @var \Drupal\Core\Annotation\Translation (optional)
+   * @var \Drupal\Core\Annotation\Translationoptional
    */
   public $description = '';

  • pifagor committed 6e18bb1 on 8.x-3.x 
    Issue #2969435 by imshivani, bhanuprakashnani, riddhi.addweb: Use Short...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.