CommentFileSizeAuthor
#7 SHORT23.png978.22 KBriddhi.addweb
#6 eu_cookie_compliance_short_array_2969157_6.patch40.92 KBnkoporec
#6 eu_cookie_compliance_diff_3_6.txt715 bytesnkoporec
#3 short-array-1.patch40.42 KBimshivani

Comments

imshivani created an issue. See original summary.

svenryen’s picture

svenryen commented

@imshivani, are you planning to contribute a patch? I have no capacity to work on this until after 25th May.

imshivani’s picture

imshivani commented
Status: Active » Needs review
StatusFileSize
new short-array-1.patch40.42 KB

@svenryen I have changed array() to [] as per new coding standards. Attached is the patch for the same.

Status: Needs review » Needs work

The last submitted patch, 3: short-array-1.patch, failed testing. View results

svenryen’s picture

svenryen commented

Thanks! Can you fix the parse error?

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs work » Needs review
StatusFileSize
new eu_cookie_compliance_diff_3_6.txt715 bytes
new eu_cookie_compliance_short_array_2969157_6.patch40.92 KB

Created a new patch with a fixed parse error.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new SHORT23.png978.22 KB

@nkoporec, your patch is working fine as per pareview report, I attached the errors that solved by you.

svenryen’s picture

svenryen commented

@riddhi.addweb thanks for the review.
Out of curiosity: I see you have a line saying "Possible useless method overriding detected". Do you know anything about that warning?

  • svenryen committed c6f1010 on 8.x-1.x authored by nkoporec 
    Issue #2969157 by nkoporec, imshivani, riddhi.addweb: Use Short Array (...
svenryen’s picture

svenryen commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.