Coding standard issue For d8 version

Create Patch for Hook_help.

@amit.drupal : Patch applied cleanely

Below points needs work:
2. UPPER CASE title in readme file
3.dependencies should be as per standard.

@amit.drupal thanks for adding the help for this module. There were many things which you missed out.

1) While applying patch got these warnings

permission_report-README-2969148.patch:18: trailing whitespace.
    $output .= '<p>' . t('This module lets you drill down into permissions much more deeply than the     
permission_report-README-2969148.patch:21: trailing whitespace.
    $output .= '<p>' . t('Much of the functionality of this module was modeled after Active Directory 
Checking patch permission_report.module...
Applied patch permission_report.module cleanly.
warning: 2 lines add whitespace errors.

3) To check coding standards errors run this command for the contributed modules
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md Module_Name

2) While submitting patch the format should be patch-description-issue_number-comment_number.patch

I have fixed all the coding standard issues for this module which were fixed, along with adding dependencies in info.yml as per standards. README.md is already in uppercase, this requires no fix. Added the patch along with interdiff.txt

@chishah92:

Thanks for adding the patch for this module. i have applied your patch , While applying patch got these warnings.

coding-standard-fixes-2969148-7.patch:36: trailing whitespace.
      $output .= '<p>' . t('This module lets you drill down into permissions much more deeply than the
coding-standard-fixes-2969148-7.patch:39: trailing whitespace.
      $output .= '<p>' . t('Much of the functionality of this module was modeled after Active Directory
Checking patch permission_report.info.yml...
Checking patch permission_report.module...
Checking patch src/Controller/ReportController.php...
Applied patch permission_report.info.yml cleanly.
Applied patch permission_report.module cleanly.
Applied patch src/Controller/ReportController.php cleanly.
warning: 2 lines add whitespace errors.

And I found README file don't follow the drupal standard so i have create patch for the README file.

@Akshay kashyap Your Patch is clean and looking good stage.

Hi @Akshay kashyap,

I reviewed your patch and it looks fine to me.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/permission_report-2969148$ git apply -v permission_report-README-2969148-8.patch
Checking patch README.md...
Applied patch README.md cleanly.

Hi,

I worked on some more issues, please review this patch.

Thanks

Patch #12 cant be applied.

Got this error.

 git apply -v permission_report
fatal: can't open patch 'permission_report': No such file or directory
abhijith.s@Y2Y2GR6GCV permission_report % git apply -v permission_report-2969148-12.patch
Checking patch README.md...
Checking patch permission_report.info.yml...
error: while searching for:
description: 'Calculates and displays the a permission report for a user and shows which roles grant what permission for a given user.  Also provides ability to list users in a role, and dig down into complicated role and permission problems.'
type: module
core: 8.x
package: Permissions
version: dev
dependencies:
  - user
error: patch failed: permission_report.info.yml:2
error: permission_report.info.yml: patch does not apply
Checking patch permission_report.module...
Checking patch permission_report.permissions.yml...
Checking patch src/Controller/ReportController.php...

Fixed fail issue in patch #12.
Also fixed the remaining issues as well.

FILE: /src/Controller/ReportController.php
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------
 264 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 326 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead

I'm unable to create the interdiff file.