Provide a readme file with the exact description of the theme.

CommentFileSizeAuthor
#13 readme-2969118-13.patch2.35 KBbandanasharma
#11 readme-2969118-11.patch2.11 KBjithin prabhakaran
#7 readme-2969118-7.patch2.34 KBbandanasharma
#5 PATCH2.png154.93 KBriddhi.addweb
#5 image (13).png93.15 KBriddhi.addweb
#4 readme-2969118-4.patch2.33 KBbandanasharma
#2 readme-2969118-1.patch1.52 KBjithin prabhakaran

Comments

jithin prabhakaran created an issue. See original summary.

jithin prabhakaran’s picture

jithin prabhakaran commented
Status: Active » Needs review
StatusFileSize
new readme-2969118-1.patch1.52 KB

The patch is uploaded.
Please review it.

bandanasharma’s picture

bandanasharma commented

#2 patch apply successfully. But theme information is missing and need some word changes like Module to Extend.

bandanasharma’s picture

bandanasharma commented
StatusFileSize
new readme-2969118-4.patch2.33 KB

Add the patch with some modification. Please review the patch.

riddhi.addweb’s picture

riddhi.addweb commented
StatusFileSize
new image (13).png93.15 KB
new PATCH2.png154.93 KB

@bandanasharma, Thanks for the patch, your patch is working fine still, some issue is there which I described in the screenshot.

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
bandanasharma’s picture

bandanasharma commented
StatusFileSize
new readme-2969118-7.patch2.34 KB

@riddhi.addweb I made changes according to your review, add the patch again.

bandanasharma’s picture

bandanasharma commented
Status: Needs work » Needs review
Neetika K’s picture

Neetika K commented
Status: Needs review » Reviewed & tested by the community

#8 : Now the characters are not going beyond 80.Tested the same.

jithin prabhakaran’s picture

jithin prabhakaran commented

The theme has been updated by using bootstrap components. So the readme file has to be entirely changed.

jithin prabhakaran’s picture

jithin prabhakaran commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new readme-2969118-11.patch2.11 KB

The patch has been applied.
Please review it.

bandanasharma’s picture

bandanasharma commented
Status: Needs review » Needs work

@jithin prabhakaran patch is apply successfully. But find some standard issues

Text manually word-wrapped within around 80 cols

Some lines word-wrapped more then 80 cols.

Two lines prior to headings (except the first one)

This is missing.

Numbered lists indented 4 spaces

Find no space in numbered list.

bandanasharma’s picture

bandanasharma commented
Status: Needs work » Needs review
StatusFileSize
new readme-2969118-13.patch2.35 KB

Updated the patch and also add Contents of this file and Maintainers section in this patch.

  • zyxware committed 1b005bb on 8.x-1.x authored by bandanasharma 
    Issue #2969118 by bandanasharma, jithin prabhakaran, riddhi.addweb:...
zyxware’s picture

zyxware commented
Status: Needs review » Fixed

Applied the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.