Moderated By: drpal

*Hello! Welcome to to our weekly JavaScript initiative meeting. It happens every Monday right here in Slack!*

- This meeting is chat-only. There is no video or audio component.
- We leave about 5 minutes between topics, sometimes more, so that people who are multitas- The meeting is threaded, so please keep an eye on thread notifications (this may not pop an alert depending on your settings.)
- Please DM me or @justafish if you would like any items added to today’s agenda

:arrow_left: :v: :arrow_right:

This message was deleted.

drpal So some things happened over the weekend.
drpal There’s a branch here,
drpal Which contains some of the work.

1️⃣ Please introduce yourself if you’re attending today’s meeting!

drpal Matt!
justafish Sally from London :arrow_left: :v: :arrow_right:
drpal (the person who doesn’t know how to run this meeting)
eatings David from Taiwan!
drpal :scream:
mixologic Hi, I was summoned by mention of DrupalCI - Ryan, from the DA
dawehner Daniel, my name
xjm Halfway here :slightly_smiling_face:
prestonso Preston in New York
lauriii Hello! Sorry I’m late! I’m Lauri and joining from Bangkok!

2️⃣ Nightwatch & DrupalCI updates.

drpal Alright.
drpal There is some work here,
drpal Which kind of works.
drpal Big thanks to @justafish @dawehner and @mixologic!
justafish
drpal @justafish thanks.
dawehner Key steps which are still required there
dawehner :A: Figure out a nice way to call to a local URL like /login without having to specify the base url
drpal I am working on `A` right now.
dawehner :B: Figure out how to install drupal and take that into account in a cookie. Reviews on are welcome
justafish my usual solution for that is to make a shared.js file alongside globals.js and add $1 to it
drpal @justafish have you seen ?
dawehner @justafish it would be nice to not have to define it though
mixologic also, it wont be on localhost, we'll need a way to tell it where its at.
drpal There is also some interesting bits on custom commands which we could do.
justafish I haven’t - that’s great @drpal!
mixologic oh, but we could easily env that part too.
justafish @drpal I’ve written lots of custom commands, I can help with that
justafish to abstract things like .login()
dawehner @justafish That is nice as well. I can come up with a list of things the PHP test does right now and which would be nice to have in nightwatch as well
justafish that’d be great!
drpal @dawehner Can you make an issue on that repo?
drpal And we can just tackle them individually?
dawehner @drpal Good idea, I'm writing together the list of stuff
drpal yay!
dawehner :C: @justafish pointed out that nightwatch supports junit. I'm wondering whether we need some custom code on the testbot to parse it in the way it needs it to be. @mixologic Do you have an opinion about that?
mixologic the only thing we need is to have it output into a place where jenkins is going to look for it.
justafish +1 to GitHub issue - make a list of checkboxes
mixologic so my plan was to make sure that it output it as junit to the right places.
dawehner @mixologic Oh that's it? I saw that the php one does some additional parsing, but I guess that's fine
justafish here’s some example output from the test in @drpal’s branch
justafish ```
<?xml version="1.0" encoding="UTF-8" ?>
<testsuites errors="0"
failures="0"
tests="1">

<testsuite name="index"
errors="0" failures="0" hostname="" id="" package="index" skipped="0"
tests="1" time="3.866" timestamp="Fri, 08 Dec 2017 23:31:45 GMT">

<testcase name="Demo Drupal.org" classname="index" time="3.866" assertions="2">

</testcase>

</testsuite>
</testsuites>

```

mixologic @dawehner thats because the junit that run-tests.sh outputs is bad, so we had to fix it to work properly. once everything is converted to phpunit we can just use phpunit's junit output as well withoutwithout modifying it.
dawehner @mixologic LOL
dawehner @mixologic So given that @justafish's output looks pretty nice
mixologic so yeah, the only thing I really need to do is make sure that the junit that nightwatch puts out gets placed into the right directory so jenkins will parse it.
dawehner @mixologic Do you see any additional points we need to address conceptually?
mixologic We'll need to try and break it in weird ways to see what sort of exit codes we get, and experiment with parallelization (multiple sessions etc).
dawehner @mixologic He, sounds like the usual issues :slightly_smiling_face:
mixologic That and a howto doc for contrib maintainers once we've got a stable thing for them to work with.
dawehner :troll: We need to integrate it into the simpletest UI
mixologic We can work on that after we build an AI that can build that for us.

Comments

justafish created an issue. See original summary.

justafish credited drpal.

justafish’s picture

Status: Active » Fixed
justafish’s picture

Title: Weekly Meeting - 2017/12/11 » [Weekly Meeting] 2017/12/11

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

justafish’s picture

Title: [Weekly Meeting] 2017/12/11 » [Admin UI & JavaScript Modernisation Initiative Weekly Meeting] 2017/12/11
Project: Drupal core - JavaScript Modernization Initiative » Drupal core
Version: » 9.x-dev
Component: Meetings » meetings

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.