When users are successfully logged in the redirect does not seem to work if there is no Destination Parameter in the URL, as \Drupal::destination()->get() will return the current URL if the Destination Parameter is empty.

CommentFileSizeAuthor
#4 ldap_sso-improve_destination_handling_successful_login-2968791-4.patch2.09 KBaaronmchale
#2 ldap_sso-improve_destination_handling_successful_login-2968791-2.patch2.14 KBaaronmchale

Comments

AaronMcHale created an issue. See original summary.

aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Assigned: aaronmchale » Unassigned
Status: Active » Needs review
StatusFileSize
new ldap_sso-improve_destination_handling_successful_login-2968791-2.patch2.14 KB

Status: Needs review » Needs work

The last submitted patch, 2: ldap_sso-improve_destination_handling_successful_login-2968791-2.patch, failed testing. View results

aaronmchale’s picture

aaronmchale
Primary language English
Location Edinburgh, Scotland
commented
Status: Needs work » Needs review
StatusFileSize
new ldap_sso-improve_destination_handling_successful_login-2968791-4.patch2.09 KB

The only difference between #2 and #4 is #4 has a new line at the end of the patch file, remember kids always put new lines at the end of your patch files otherwise the CI Server will fail them lol

grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Needs review » Fixed

Thanks for that patch, applied with a minor cosmetic change.

Did not know that Request is available out of the box, neat!

  • grahl committed eef841c on 8.x-1.x authored by AaronMcHale 
    Issue #2968791 by AaronMcHale: Improve destination handling on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Closed (fixed) » Closed (outdated)

Edit on wrong ticket.

grahl’s picture

grahl
he/him
Location Zürich
commented
Status: Closed (outdated) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.