PHPStorm finds multiple definitions for drupal_set_message:
- drupal_set_message in ./core/include/bootstrap.inc
- drupal_set_message in ./modules/pathauto/tests/src/Unit/VerboseMessengerTest.php
As a result, the function is not marked as deprecated in PHPStorm.
Do not try to (re-)declare the drupal_set_message function in VerboseMessengerTest.
drupal_set_message is flagged as deprecated in PHPStorm
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | pathauto-drupal_set_message_declaration-2968718-12.patch | 5.81 KB | idebr |
| #12 | interdiff-8-12.txt | 294 bytes | idebr |
Comments
Comment #2
berdirThis was necessary in the past, now we can update the service to use the messenger service.
Comment #3
vakulrai commented@idebr adding a patch, which will remove drupal_set_message function in VerboseMessengerTest file.
Comment #5
berdirYes, you can not just remove the function, you need to remove the usage of it in VerboseMessenger and replace it with the service.
Comment #6
idebr commentedAttached implements the following changes:
No interdiff with #3 since the approach is different from that patch.
Comment #8
idebr commentedAdded CoreMessengerInterface to prevent confusion with \Drupal\pathauto\MessengerInterface
Comment #9
vakulrai commentedI have used use Drupal\Core\Messenger\MessengerInterface service.
Comment #11
berdirPatch in #8 looks good, can we also put an explicit 8.5+ dependency to pathauto.info.yml?
Comment #12
idebr commented#11 Added dependency to drupal:system (>= 8.5) based on a similar implementation in webform: #2885419: Upgrade to Drupal 8.3.x
Comment #14
berdirThanks, yeah, like that.
@vakulrai: Before starting to work on something, it makes sense to ask the issue author if he's working on it, especially if it's a very new issue. That said, would have been clearer if @idebr would have assigned the issue to himself to clarify that he is working on it. So I gave you issue credits despite your patches not being used.
Comment #15
idebr commented@Berdir Thanks for your reviews and quick action. I'll make sure to assign an issue to myself in the future.