I can't find any purpose for $mapping->status or $mapping->locked, and the description on the form simply states 'Not yet in use'. This should at the very least have a link to some feature plan, otherwise it's adding needless confusion to an already drupally interface. I can only see commented out form array assignments in validation asking 'what does locked even mean?'.
Can this be removed entirely? If so I will submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | salesforce-remove_unused_mapping_properties-2968664-9.patch | 6.18 KB | aaronbauman |
Comments
Comment #2
aaronbauman"status" should allow enable / disable of a mapping.
"locked" should prevent / allow the mapping to be edited.
Comment #3
michaelmallett commentedBut it doesn't actually do anything at the moment, so it's confusing to have these form fields. I reckon we at least comment these fields out with a @todo.
From my own personal experience, when something goes wrong and trying to debug the module, it's wasted time for anyone to search through the code to find out what these do (which is nothing), 'Not Yet In Use' is insufficient. I realise drupal modules seem to have a strict policy of limited word counts in their descriptions and documentation but at the least it should be more descriptive, even if it saves someone ten minutes of confusion/frustration it's worth it.
Comment #4
aaronbaumanVery reasonable suggestion.
I'm happy to get rid of them until someone has time to make them work.
Comment #5
aaronbaumanThis will go into the next release unless it causes some problems.
Let me know.
Comment #7
aaronbaumanOK, I guess schema API requires that we have a status field (?!?!?)
Comment #9
aaronbaumanwrong patch.
Comment #11
aaronbaumancommitted