The module currently installs itself as a tab on the configuration synchronization page in admin/configure. However, this page is not a configuration page (as far as I can tell), but rather is reporting the current state of configuration on the site. Therefore, I feel that this page would be more logically located in admin/reports than in admin/configuration.

Comments

Jaypan created an issue. See original summary.

gábor hojtsy’s picture

Yeah it was originally in reports, see https://cgit.drupalcode.org/config_inspector/commit/?id=65e319a816db83ff... where we moved it out of there. More feedback on the desired location of this would be nice, so we don't keep moving it around. Unfortunately that was moved without an issue. If there would have been an issue at the time, we could see the discussion that happened then :)

idebr’s picture

Drupal Core has a similar inspection for entity definitions that is reported on the 'Status report':

image of error

I would suggest to make a similar entry for configuration entity schema errors and revert 65e319a816, in line with the Entity definitions mismatches reported by Drupal core.

jaypan’s picture

There were two primary reasons I opened this thread, both of which relate to the intuitiveness of the current location:

1) The inspector is currently a tab of Configuration Synchronizarion. But the functionality is not synchronizing configuration, it is inspecting/viewing it. The logical move here would be to move this functionality parallel to the Configuration Synchronization item. However:

2) Doing the above would place the item At Config -> Development, and this is not really configuration. It is actually more of a report, which is why I suggest moving it into reports.

I should also add that I think including configuration errors on the status report page is a great idea. This would be a great additional feature on top of moving the inspector.

sakiland’s picture

+1 for moving into reports and including configuration errors on the status report page

idebr’s picture

gábor hojtsy’s picture

Issue tags: +Needs screenshots

It is not just about reverting 65e319a816 as there are all the routes defined in the routing.yml that would still be using the admin/config path. I am fine with moving it (back) there, can someone please provide a patch? Also a screenshot of the reports page would be nice so we can see if it fits in with the other items. Thanks!

idebr’s picture

Issue summary: View changes
Status: Active » Needs review
Issue tags: -Needs screenshots
StatusFileSize
new4.95 KB
new555.46 KB

Attached patch implements the following changes:

  1. Adds a menu link to admin/reports/config-inspector from #2757413: Create a menu item for the inspect page
  2. Removes the local task for the overview page, since it is not really on the same level as the other tasks.

Screen capture after applying patch:

gábor hojtsy’s picture

Thanks. The reason I was looking to have a screenshot of the reports page is that if you look at the menu items, neither has a verb in it, after all its reports, not things "to do" but things to "look at" :) I wonder what would be a better menu item title for this that fits better with the reports menu items. "Configuration" would come naturally but that may be misleading for some believing they would configure their reports. Maybe "Configuration inspector" would be best? That leads with the word you are looking for but not misleading. Also matches the module name :D

idebr’s picture

StatusFileSize
new977 bytes
new4.95 KB

#9 I agree that 'Configuration inspector' is a better label. I updated the patch accordingly.

gábor hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

  • Gábor Hojtsy committed 6a9b0d5 on 8.x-1.x
    Issue #2968628 by idebr, Jaypan: Move location of inspector page to...
gábor hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.