Closed (fixed)
Project:
Configuration Inspector
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 May 2018 at 21:52 UTC
Updated:
8 Nov 2018 at 19:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gábor hojtsyYeah it was originally in reports, see https://cgit.drupalcode.org/config_inspector/commit/?id=65e319a816db83ff... where we moved it out of there. More feedback on the desired location of this would be nice, so we don't keep moving it around. Unfortunately that was moved without an issue. If there would have been an issue at the time, we could see the discussion that happened then :)
Comment #3
idebr commentedDrupal Core has a similar inspection for entity definitions that is reported on the 'Status report':
I would suggest to make a similar entry for configuration entity schema errors and revert
65e319a816, in line with the Entity definitions mismatches reported by Drupal core.Comment #4
jaypanThere were two primary reasons I opened this thread, both of which relate to the intuitiveness of the current location:
1) The inspector is currently a tab of Configuration Synchronizarion. But the functionality is not synchronizing configuration, it is inspecting/viewing it. The logical move here would be to move this functionality parallel to the Configuration Synchronization item. However:
2) Doing the above would place the item At Config -> Development, and this is not really configuration. It is actually more of a report, which is why I suggest moving it into reports.
I should also add that I think including configuration errors on the status report page is a great idea. This would be a great additional feature on top of moving the inspector.
Comment #5
sakiland commented+1 for moving into reports and including configuration errors on the status report page
Comment #6
idebr commentedFiled #3009151: Show configuration schema errors on the status report page to prevent scope creep for this issue.
Comment #7
gábor hojtsyIt is not just about reverting
65e319a816as there are all the routes defined in the routing.yml that would still be using the admin/config path. I am fine with moving it (back) there, can someone please provide a patch? Also a screenshot of the reports page would be nice so we can see if it fits in with the other items. Thanks!Comment #8
idebr commentedAttached patch implements the following changes:
admin/reports/config-inspectorfrom #2757413: Create a menu item for the inspect pageScreen capture after applying patch:
Comment #9
gábor hojtsyThanks. The reason I was looking to have a screenshot of the reports page is that if you look at the menu items, neither has a verb in it, after all its reports, not things "to do" but things to "look at" :) I wonder what would be a better menu item title for this that fits better with the reports menu items. "Configuration" would come naturally but that may be misleading for some believing they would configure their reports. Maybe "Configuration inspector" would be best? That leads with the word you are looking for but not misleading. Also matches the module name :D
Comment #10
idebr commented#9 I agree that 'Configuration inspector' is a better label. I updated the patch accordingly.
Comment #11
gábor hojtsyComment #13
gábor hojtsyThanks!