in Safari I am getting this error:

Error: Quick Edit could not associate the rendered entity field markup (with [data-quickedit-field-id="profile/2/field_profile_address/und/default"]) with the corresponding rendered entity markup: no parent DOM node found with [data-quickedit-entity-id="profile/2"]. This is typically caused by the theme's template for this entity type forgetting to print the attributes.

but it works for other fields.

Comments

SocialNicheGuru created an issue. See original summary.

socialnicheguru’s picture

I do not see the error on initial page load.
In this case the page is a profile with an address field.

I click edit then save.

Then the error comes up

socialnicheguru’s picture

socialnicheguru’s picture

Status: Active » Needs review
dww’s picture

Status: Needs review » Needs work

Can't we put the attributes on the existing <p> tag instead of introducing Yet Another Div?

dww’s picture

Issue tags: +Needs tests

Also, does this work with the default formatter, but not plain?

Finally, it'd be great to have some tests related to this.

sickness29’s picture

Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new6.64 KB

Added test to check quickedit with address field using both plain and default formatters.
I have not included original fix from #3 because tests do not fail and I was not able to reproduce issue in safari for both article_test content type and for test profile type I created.
Let me know if we still need to add attributes to p element to make sure those attributes are not lost.

sickness29’s picture

StatusFileSize
new6.68 KB

Fixed small code standards issue

sickness29’s picture

StatusFileSize
new6.7 KB

Looks like it won't pass because quickedit is deprecated and we need to mark it as legacy group test. hopefully passes this time

bojanz’s picture

Category: Bug report » Support request
Status: Needs review » Fixed

Big thank you for writing a test and confirming quickedit now works, sickness29!

However, I don't think it's wise to commit this test, because it can't pass on D10 (where quickedit doesn't exist anymore), and 8.x-1.x wants to keep working on D10 since people won't move to 2.0.x immediately.

So, perhaps it's best to just mark this as fixed?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.