Closed (fixed)
Project:
Address
Version:
8.x-1.3
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
1 May 2018 at 04:30 UTC
Updated:
30 Nov 2023 at 13:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
socialnicheguru commentedI do not see the error on initial page load.
In this case the page is a profile with an address field.
I click edit then save.
Then the error comes up
Comment #3
socialnicheguru commentedComment #4
socialnicheguru commentedComment #5
dwwCan't we put the attributes on the existing
<p>tag instead of introducing Yet Another Div?Comment #6
dwwAlso, does this work with the default formatter, but not plain?
Finally, it'd be great to have some tests related to this.
Comment #7
sickness29 commentedAdded test to check quickedit with address field using both plain and default formatters.
I have not included original fix from #3 because tests do not fail and I was not able to reproduce issue in safari for both article_test content type and for test profile type I created.
Let me know if we still need to add attributes to p element to make sure those attributes are not lost.
Comment #8
sickness29 commentedFixed small code standards issue
Comment #9
sickness29 commentedLooks like it won't pass because quickedit is deprecated and we need to mark it as legacy group test. hopefully passes this time
Comment #10
bojanz commentedBig thank you for writing a test and confirming quickedit now works, sickness29!
However, I don't think it's wise to commit this test, because it can't pass on D10 (where quickedit doesn't exist anymore), and 8.x-1.x wants to keep working on D10 since people won't move to 2.0.x immediately.
So, perhaps it's best to just mark this as fixed?