This is just a pure move-around to make reading the setUp method a little easier.

CommentFileSizeAuthor
#4 2968015-4.patch7.1 KBgabesullice
#4 interdiff-2-4.txt402 bytesgabesullice
#2 interdiff--2.txt801 bytesgabesullice
#2 2968015-2.patch7.14 KBgabesullice
move-field-setup.patch7.87 KBgabesullice

Comments

gabesullice created an issue. See original summary.

gabesullice’s picture

gabesullice
Primary language English
commented
StatusFileSize
new 2968015-2.patch7.14 KB
new interdiff--2.txt801 bytes

CS and leftover code cleanup, will commit if tests pass.

gabesullice’s picture

gabesullice
Primary language English
commented

Failing tests are due to #2968019: EntityViewDisplayTest broken on 8.6

Will retest after that lands.

gabesullice’s picture

gabesullice
Primary language English
commented
StatusFileSize
new interdiff-2-4.txt402 bytes
new 2968015-4.patch7.1 KB

Okay, HEAD is fixed.

One more change to ensure that the patch is not making any behavioral changes.

  • gabesullice committed bc64838 on 8.x-1.x 
    Issue #2968015 by gabesullice: Break out ResourceTestBase field-related...

  • gabesullice committed 0e953e9 on 8.x-2.x 
    Issue #2968015 by gabesullice: Break out ResourceTestBase field-related...
gabesullice’s picture

gabesullice
Primary language English
commented
Status: Needs review » Fixed

Passing 8.5, 8.6 on 1.x & 2.x. Committed.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Looks okay.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.