Hi!

Just a few coding standards improvements.

CommentFileSizeAuthor
#7 interdiff-2967990-2-7.txt2.66 KByogeshmpawar
#7 2967990-7.patch4.08 KByogeshmpawar
#3 2967990.png183 KBlomasr
#2 coding-standard-fix-2967990-2.patch2.16 KBvinod_kc

Comments

vinod_kc created an issue. See original summary.

vinod_kc’s picture

vinod_kc commented
StatusFileSize
new coding-standard-fix-2967990-2.patch2.16 KB

Patch with fixes.

lomasr’s picture

lomasr commented
StatusFileSize
new 2967990.png183 KB

#2 patch worked cleanly for me

lomasr’s picture

lomasr commented
Status: Active » Needs review
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, marking as RTBC.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: Unassigned » yogeshmpawar
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
StatusFileSize
new 2967990-7.patch4.08 KB
new interdiff-2967990-2-7.txt2.66 KB

Added few more changes in current patch & also added an interdiff.

  • Yogesh Pawar committed 6160459 on 8.x-1.x 
    Issue #2967990 by Yogesh Pawar, vinod_kc, lomasr, nkoporec: Coding...
yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location Pune(MH), INDIA 🇮🇳
commented
Assigned: yogeshmpawar » Unassigned
Status: Reviewed & tested by the community » Fixed

Committed & Pushed to 8.x-1.x branch.
Thanks @vinod_kc, @lomasr, @nkoporec for working on this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.