I want to include some extra configuration before create a beta release

- #2966798: Include an admin page with configuration about where include a slash
- #2966800: Improve documentation

Comments

mgzrobles created an issue. See original summary.

mgzrobles’s picture

mgzrobles commented
Issue summary: View changes
mgzrobles’s picture

mgzrobles commented
Issue summary: View changes
batkor’s picture

batkor
Location Irkutsk
commented

hi @mgzrobles
I believe that use "void" excess in TrailingSlashServiceProvider function

public function alter(ContainerBuilder $container): void {
    if (
          $container->hasDefinition('url_generator.non_bubbling')
      &&  $container->hasDefinition('path_processor_language')
    ) {
      $container->getDefinition('url_generator.non_bubbling')
                ->setClass('Drupal\trailing_slash\Routing\TrailingSlashUrlGenerator')
                ->addArgument(new Reference('path_processor_language'));
    }
  }

may call error Parse error: syntax error, unexpected ':', expecting ';' or '{' in

Sorry for my bad english

mgzrobles’s picture

mgzrobles commented

Hi @batkor
which version of PHP do you use? I think that it is ok in PHP 7.1

batkor’s picture

batkor
Location Irkutsk
commented

OOO. yes it is ok in 7.1
My default version for Server php 5.4 and use Drupal console call warning massage

mgzrobles’s picture

mgzrobles commented

I just included the new stable version
https://www.drupal.org/project/trailing_slash/releases/8.x-1.0

mgzrobles’s picture

mgzrobles commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.