\Drupal\feeds\Entity\Feed::startCronImport() tries to call startCronImport() on a \Drupal\feeds\FeedImportHandler instance, but that class does not have a method with that name yet.

Let's implement that method. It should create a queue task.

CommentFileSizeAuthor
#12 interdiff-2966684-10-12.txt957 bytesmegachriz
#12 feeds-start-cron-import-2966684-12.patch5.11 KBmegachriz
#10 interdiff-2966684-07-10.txt2.14 KBmegachriz
#10 feeds-start-cron-import-2966684-10.patch5.1 KBmegachriz
#7 interdiff-2966684-6-7.txt1.12 KBmegachriz
#7 feeds-start-cron-import-2966684-7.patch5.55 KBmegachriz
#6 interdiff-2966684-4-6.txt1.5 KBmegachriz
#6 feeds-start-cron-import-2966684-6.patch4.63 KBmegachriz
#4 interdiff-2966684-2-4.txt1.54 KBmegachriz
#4 feeds-start-cron-import-2966684-4.patch3.82 KBmegachriz
#2 feeds-start-cron-import-2966684-2.patch3.07 KBmegachriz

Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Active » Needs review
StatusFileSize
new feeds-start-cron-import-2966684-2.patch3.07 KB

Status: Needs review » Needs work

The last submitted patch, 2: feeds-start-cron-import-2966684-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-start-cron-import-2966684-4.patch3.82 KB
new interdiff-2966684-2-4.txt1.54 KB

The queue name contains the ID of the feed.

Status: Needs review » Needs work

The last submitted patch, 4: feeds-start-cron-import-2966684-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-start-cron-import-2966684-6.patch4.63 KB
new interdiff-2966684-4-6.txt1.5 KB

Some references to the queue refer to the feed bundle and others to the feed ID. This may be well the reason that #2820548: Fatal error when triggering Feeds via cron happens.

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds-start-cron-import-2966684-7.patch5.55 KB
new interdiff-2966684-6-7.txt1.12 KB

Also covers exception thrown when trying to start a cron import task on a locked feed.

The last submitted patch, 6: feeds-start-cron-import-2966684-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 7: feeds-start-cron-import-2966684-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-start-cron-import-2966684-10.patch5.1 KB
new interdiff-2966684-07-10.txt2.14 KB

Hm. The queue name does need to contain the feed's bundle. Else the queue cannot be cleaned up when deleting the feed type.

Status: Needs review » Needs work

The last submitted patch, 10: feeds-start-cron-import-2966684-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs work » Needs review
StatusFileSize
new feeds-start-cron-import-2966684-12.patch5.11 KB
new interdiff-2966684-10-12.txt957 bytes

Use $this->t() instead of 'FormattableMarkup' in FeedImportHandler and use \Drupal::time()->getRequestTime() instead of REQUEST_TIME.

  • MegaChriz committed 2e32297 on 8.x-3.x 
    Issue #2966684 by MegaChriz: Implemented FeedImportHandler::...
megachriz’s picture

megachriz
Primary language Dutch
commented
Status: Needs review » Fixed

Great! Tests are passing now. Committed #12.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.