CommentFileSizeAuthor
#8 apply-patch.png48.96 KBbrahmjeet789
#7 short_array-2966671-6.patch5.95 KBvakulrai
#6 short_array-2966671-6.patch5.95 KBvakulrai
#2 short-array-1.patch5.95 KBimshivani

Comments

imshivani created an issue. See original summary.

imshivani’s picture

imshivani commented
Status: Active » Needs review
StatusFileSize
new short-array-1.patch5.95 KB

I have changed array with the new coding standards. Attached is the patch for the same.

Status: Needs review » Needs work

The last submitted patch, 2: short-array-1.patch, failed testing. View results

akash.addweb’s picture

akash.addweb commented

@imshivani, Thanks for providing the patch, but still needs for the correction. Review the given link in which It shows all files which need the same changes & that are missed.
Refer: https://pareview.sh/pareview/https-git.drupal.org-project-features.git-8...

imshivani’s picture

imshivani commented

@Ronak.addweb Thanks for providing me with the enough information. I'll be reworking on the issue.

vakulrai’s picture

vakulrai commented
StatusFileSize
new short_array-2966671-6.patch5.95 KB

@imshivani i have tested your patch it applies cleanly but having php lint error for short array syntax, adding a patch for the same.

vakulrai’s picture

vakulrai commented
Status: Needs work » Needs review
StatusFileSize
new short_array-2966671-6.patch5.95 KB

@imshivani i have tested your patch it applies cleanly but having php lint error for short array syntax, adding a patch for the same.

brahmjeet789’s picture

brahmjeet789 commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new apply-patch.png48.96 KB

@vakul: i have applied your patch and it applied sucessully and now i can see [] instead of array().

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Applied, thanks!

  • nedjo committed a2316ef on 8.x-3.x authored by vakulrai 
    Issue #2966671 by vakulrai, imshivani, brahmjeet789: Use Short Array (...
akash.addweb’s picture

akash.addweb commented

@nedjo, Thanks for committing this patch, but I think you forgot to provide me the credit of this contribution. Can you please do the needful As I'm the part of RTBC.
Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.