Gateway settings lost during upgrade for AcceptJS and eCheck plugin split

This is in reference to: commerce_authnet_post_update_echeck

See http://cgit.drupalcode.org/commerce_authnet/commit/?id=365ce4922fa01abe1...

The gateway plugin is split into two different gateways. So the Client ID issue existed before this.

Updating to strike out "the default transaction type switched from "Authorization and capture" to "Authorization only". This is handled by the checkout flow directly. See #2953806: Setting gateway to "authorization only" has no effect?

Started to write test.

Time: 6.37 seconds, Memory: 6.00MB

There was 1 error:

1) Drupal\Tests\commerce_authnet\Kernel\PluginUpgradeTest::testBasicUpgrade
Drupal\Component\Plugin\Exception\PluginNotFoundException: The "authorizenet" plugin does not exist.

Need to generate a database fixture to test with, using old revision like 0fb85dcbf46cf4fe4b1942a56af7fee66e36a484.

Creating a test fixture based on the commit 0fb85dcbf46cf4fe4b1942a56af7fee66e36a484

Here is a test with a fixture that upgrades a gateway plugin made on c65e90993f8b4919ed427043ace4e960202092e0 and upgraded.

--- Expected
+++ Actual
@@ @@
 Array (
     'mode' => 'test'
-    'api_login' => 'TESTING_WITH_FAKE_LOGIN_ID'
-    'transaction_key' => 'TESTING_WITH_FAKE_TRANSACTION_KEY'
+    'api_login' => ''
+    'transaction_key' => ''
     'client_key' => ''
     'display_label' => 'Authorize.net'
     'payment_method_types' => Array (...)
 )

Found the problem. Setting the plugin ID purges the configuration. Uploading a patch which fails and has the fix commented out.

  /**
   * {@inheritdoc}
   */
  public function setPluginId($plugin_id) {
    $this->plugin = $plugin_id;
    $this->configuration = [];
    $this->pluginCollection = NULL;
    return $this;
  }

Okay, next steps:

* Clean up
* Move communication about missing the client key to a follow-up.

This initial regression was due to the eCheck split. However, we uncovered a different upgrade issue along the way.

Here is the patch I plan to commit.

Here is a patch with the test fixture gzipped to save some disk space.

Missing binary file

Update title to be more precise.

Fixed! Opening a follow up for the AcceptJS token messaging.