Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Core issue where this was fixed in the HAL module: #2864816: HAL LinkManager doesn't add 'url.site' cache context when needed.
Discovered in #2883086-45: [PP-1] Port RequestHandler + ResourceResponseSubscriber improvements from REST module to JSON API.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2966384-4.patch | 1.89 KB | wim leers |
| #4 | interdiff.txt | 889 bytes | wim leers |
| #3 | 2966384-3.patch | 1.01 KB | wim leers |
Comments
Comment #2
wim leers(#2952714: Group module's GroupAccessResult::allowedIfHasGroupPermission(s)() does not include cacheability was originally created for this purpose, but that got derailed. So, this is a resurrection of the original issue and scope.)
Comment #3
wim leersFix the
@todo. This should fail.Comment #4
wim leersImplementing the same solution as #2864816: HAL LinkManager doesn't add 'url.site' cache context when needed seems overkill. Because every JSON API document/response contains absolute URLs. So, let's just make everything that that uses
\Drupal\jsonapi\Normalizer\JsonApiDocumentTopLevelNormalizervary byurl.site.Comment #6
gabesulliceI believe there are some cases in the resource tests that need to be (un)commented by this issue. Otherwise, LGTM.
Comment #7
wim leersIf I search for
2966384, I find only this one?Comment #8
gabesulliceDerp, looks like I reviewed the interdiff, not the patch.
Comment #11
gabesullice